Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.2k
fix(re-exports): should render use arrow getter for dynamic reexports…#20249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
… when using const as decl
|
JSerFeng commentedDec 17, 2025
I can't find the exact browserslist that supports |
alexander-akait commentedDec 17, 2025
@JSerFeng Let's fix style, just update prettier |
CodSpeed Performance ReportMerging#20249 willnot alter performanceComparing Summary
|
Uh oh!
There was an error while loading.Please reload this page.
… when using const as decl
Summary
When reexports dynamic, runtime code will like this:
However this getter only access variable
__WEBPACK_IMPORT_KEY__when it really gets invoked, but the__WEBPACK_IMPORT_KEY__is declared usingvar, which is in global scope not block scope inforstmt.That will cause every getter access the last
__WEBPACK_IMPORT_KEY__in the end.What kind of change does this PR introduce?
Fix
Did you add tests for your changes?
Yep.
Does this PR introduce a breaking change?
Nope.
If relevant, what needs to be documented once your changes are merged or what have you already documented?