Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.2k
fix: implement Object.defineProperty support in CommonJsExportRequireDependency#20004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
alexander-akait left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please add a test case
| <p>(In chronological order)</p> | ||
| -[@google](https://github.com/google) for[Google Web Toolkit (GWT)](http://www.gwtproject.org/), which aims to compile Java to JavaScript. It features a similar[Code Splitting](http://www.gwtproject.org/doc/latest/DevGuideCodeSplitting.html)as webpack. | ||
| -[@google](https://github.com/google) for[Google Web Toolkit (GWT)](http://www.gwtproject.org/), which aims to compile Java to JavaScript. It features a similar[Code Splitting](http://www.gwtproject.org/doc/latest/DevGuideCodeSplitting.html)to webpack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Avoid this change, not related to fix
| }else{ | ||
| ranges.push(`${quoteMeta(start)}-${quoteMeta(prev)}`); | ||
| } | ||
| return`[${ranges.join("")}]`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Avoid this change, not related to fix
hai-x commentedOct 12, 2025
To be honest, I don’t think we currently support parsing reexport for |
evenstensberg commentedOct 16, 2025
@hai-x Lets keep this open until its fixed. |
Summary
This PR implements missing Object.defineProperty support in CommonJsExportRequireDependency, fixing a TODO that threw runtime errors.
Changes:
throw new Error("TODO")with proper Object.defineProperty implementationWhat kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?