Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.2k
refactor: logic#19929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
refactor: logic#19929
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CodSpeed Performance ReportMerging#19929 willdegrade performances by 41.68%Comparing Summary
Benchmarks breakdown
|
Jack-Works commentedSep 24, 2025
hi! I think there is nothing wrong with the current result. A deferred namespace object is an ECMAScript module namespace object, since it's impossible to export a symbol-named entry in an ES Module (not possible to |
alexander-akait commentedSep 24, 2025
@Jack-Works I agree about |
Jack-Works commentedSep 28, 2025
The difference of exported keys: -Symbol(comet)-Symbol(meteor)+default If we change the mode, that means any symbol (even non-exist one) access will also trigger the module evaluation. I'm not sure if that is what we want. maybe cc@nicolo-ribaudo ? |
alexander-akait commentedSep 29, 2025
Yeah, let/s wait@nicolo-ribaudo answer |
What kind of change does this PR introduce?
refactor code
Did you add tests for your changes?
WIP
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing
@Jack-Works I think I found some incompatibilities with defer and without defer in our logic (and I think it is a bug):
Without defer:
index.js
module.js
Output:
With defer:
index.js
module.js
I think we should change the mode
6to8fordynamic