Consolidated SourceMap-related fields underdevtool to enhance scalability and improve developer experience (DX). Now, devtool can be defined using an object literal, like so:

{devtool:{"namespace":"webpack","moduleFilenameTemplate":"webpack://[namespace]/[resource-path]","fallbackModuleFilenameTemplate":"webpack://[namespace]/[resource-path]?[hash]","filename":"[file].map[query]","module":true,"columns":true,"noSources":true,"debugIds":true,"eval":true// This is a newly introduced option. When set to true, it behaves the same as 'eval-source-map'.}}

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

object notation ofdevtool

hai-x commented

May 1, 2025

View reviewed changes

lib/config/defaults.js

		}
		}

		F(options,"devtool",()=>(development ?"eval" :false));

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We put it after makingoptions.output default b/c we rely onoutput.uniqueName

hai-x marked this pull request as ready for review

May 1, 2025 10:30

hai-x force-pushed thefeat-devtool-object-notation branch from42ee44e to9908283Compare

May 1, 2025 12:06

Copy link

codspeed-hqbot commentedMay 1, 2025•
edited
Loading

CodSpeed Performance Report

Merging#19485 willdegrade performances by 10.48%

_{Comparinghai-x:feat-devtool-object-notation (7c87b00) withmain (19ca741)}

Summary

⚡ 80 improvements
❌ 1 regressions
✅ 40 untouched benchmarks
🆕 12 new benchmarks

⚠️Please fix the performance issues oracknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
⚡	`benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}'`	52.3 ms	11.6 ms	×4.5
🆕	`benchmark "lodash", scenario '{"name":"mode-development","mode":"development"}'`	N/A	751.1 ms	N/A
🆕	`benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}'`	N/A	30.1 ms	N/A
🆕	`benchmark "lodash", scenario '{"name":"mode-production","mode":"production"}'`	N/A	9.8 s	N/A
🆕	`benchmark "many-chunks-commonjs", scenario '{"name":"mode-development","mode":"development"}'`	N/A	247.9 ms	N/A
🆕	`benchmark "many-chunks-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}'`	N/A	61.4 ms	N/A
🆕	`benchmark "many-chunks-commonjs", scenario '{"name":"mode-production","mode":"production"}'`	N/A	2 s	N/A
🆕	`benchmark "many-chunks-esm", scenario '{"name":"mode-development","mode":"development"}'`	N/A	243.4 ms	N/A
🆕	`benchmark "many-chunks-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}'`	N/A	61.8 ms	N/A
🆕	`benchmark "many-chunks-esm", scenario '{"name":"mode-production","mode":"production"}'`	N/A	2.3 s	N/A
🆕	`benchmark "many-modules-commonjs", scenario '{"name":"mode-development","mode":"development"}'`	N/A	306.1 ms	N/A
🆕	`benchmark "many-modules-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}'`	N/A	52.3 ms	N/A
🆕	`benchmark "many-modules-commonjs", scenario '{"name":"mode-production","mode":"production"}'`	N/A	2.1 s	N/A
❌	`benchmark "react", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}'`	31.3 ms	35 ms	-10.48%
⚡	`md4 buffer benchmark (size: 10000)`	114.1 µs	73 µs	+56.26%
⚡	`md4 buffer benchmark (size: 100000)`	447.6 µs	406.7 µs	+10.08%
⚡	`md4 buffer benchmark (size: 120)`	76 µs	35 µs	×2.2
⚡	`md4 buffer benchmark (size: 160)`	76 µs	35 µs	×2.2
⚡	`md4 buffer benchmark (size: 16366)`	138.4 µs	97.4 µs	+42.13%
⚡	`md4 buffer benchmark (size: 16368)`	138.6 µs	97.4 µs	+42.2%
...	...	...	...	...

ℹ️Only the first 20 benchmarks are displayed.Go to the app to view all benchmarks.

hai-x force-pushed thefeat-devtool-object-notation branch 2 times, most recently from27ec59a to2ed2eacCompare

May 7, 2025 14:43

alexander-akait reviewed

May 21, 2025

View reviewed changes

lib/WebpackOptionsApply.js Outdated

		constcheap=devtool.type.includes("cheap");
		constmoduleMaps=devtool.type.includes("module");
		constnoSources=devtool.type.includes("nosources");
		constdebugIds=devtool.type.includes("debugids");

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ideally we should do it innormalization.js, so indefault.js we will already have object, but I am afraid it can be breaking change, because some developers can rely onoutput.devtool as a string.

There is a good question should we want to supportdevtool: string in future, if yes - code looks good, if no - we need to addTODO.

I'm actually in favor of supporting the string value in the future.

Copy link

MemberAuthor

hai-xMay 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm actually in favor of supporting the string value in the future.

Me too. I think it's not too bad to still supportingdevtool: string. So user can easily setting whendevelopment and as far as I know, if need to generate production sourcemaps they usually use plugin.

alexander-akait reviewed

May 21, 2025

View reviewed changes

lib/WebpackOptionsApply.js

		namespace:options.output.devtoolNamespace,
		namespace,
		debugIds
		}).apply(compiler);

Copy link

Member

alexander-akaitMay 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

So we don't allow to providecolumns/debugIds/etc values in the object notation or you want to finish it after this PR?

Copy link

MemberAuthor

hai-xMay 22, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Currently,columns anddebugIds depend on thedevtool setting (i.e., devtool.includes("cheap") / "debugids").

Yeah, separating them into a dedicated field is a good idea - but should we still support specifying them via string literals or bydevtool.type (e.g., cheap-xxx, debugids-xxx)?