Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.2k
fix:that the external modules load without reload when lazy-compilation#19477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
| if(!hooks){ | ||
| hooks={ | ||
| createScript:newSyncWaterfallHook(["source","chunk"]) | ||
| createScript:newSyncWaterfallHook(["code","chunk"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please avoid unnecessary changes which is not related to fixes
lib/hmr/LazyCompilationPlugin.js Outdated
| } | ||
| returnfalse; | ||
| }) | ||
| :false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Bad idea, we should register runtime insideExternalModule
| makeSerializable( | ||
| ExternalModuleInitFragment, | ||
| "webpack/lib/dependencies/ExternalModuleInitFragment" | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why it was removed?
CodSpeed Performance ReportMerging#19477 willnot alter performanceComparing Summary
|
fixes:#19134
Fixed issue with external dependencies not loading properly on first visit when lazy compilation is enabled
Added logic to ensure external dependencies are properly initialized before lazy-loaded chunks that depend on them
Enhanced the LazyCompilationProxyModule to detect and handle external dependencies
Added new runtime helper to ensure external dependencies are loaded in the correct order