Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.1k
refactor: improve external module render for libraryType: module#19416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
JSerFeng wants to merge5 commits intowebpack:mainChoose a base branch fromJSerFeng:refactor/improve-external-module-exports
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
refactor: improve external module render for libraryType: module#19416
JSerFeng wants to merge5 commits intowebpack:mainfromJSerFeng:refactor/improve-external-module-exports
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
63a0edb
to2ad9415
Compare@JSerFeng Hello, do you need help here? |
Oh, I just meet the problem that InitFragments in |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What kind of change does this PR introduce?
🚧 WIP...
improve output for external module of
library.type: module
Before:
This PR:
ExternalModule is imported though
InitFragment
, which will insert a namespace import, but user may want to keep the code as isAs we know the
exportsInfo
, we can use them to improve the output.If
exportsInfo.getUsedExports()
equals:ConcatenationScope.allUsedNames
to avoid conflictsDid you add tests for your changes?
WIP...
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?