Movatterモバイル変換

Skip to content

webpack/postcss-loaderPublic

NotificationsYou must be signed in to change notification settings
Fork209
Star2.9k

Commit8ef0c7e

mcous

authored

fix: do not crash if pkg.(d|devD)ependencies unset (#667)

1 parent84f16be commit8ef0c7eCopy full SHA for 8ef0c7e

File tree

4 files changed

+7

-10

lines changed

src
- index.js
test/fixtures/package-json-files
- no-postcss
  - package.json
- postcss-v8-in-dependencies
  - package.json
- postcss-v8-in-devDependencies
  - package.json

4 files changed

+7

-10

lines changed

`‎src/index.js‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,9 @@ export default async function loader(content, sourceMap, meta) {`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`if(pkg){`
`165`		`-if(!pkg.dependencies.postcss&&!pkg.devDependencies.postcss){`
	`165`	`+const{ dependencies={}, devDependencies={}}=pkg;`
	`166`	`+`
	`167`	`+if(!dependencies.postcss&&!devDependencies.postcss){`
`166`	`168`	`this.emitWarning(`
`167`	`169`	`newError(`
`168`	`170`	`"Add postcss as project dependency. postcss is not a peer dependency for postcss-loader. "+`

`‎test/fixtures/package-json-files/no-postcss/package.json‎`

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1 @@`
`1`		`-{`
`2`		`-"dependencies": {},`
`3`		`-"devDependencies": {}`
`4`		`-}`
	`1`	`+{}`

`‎test/fixtures/package-json-files/postcss-v8-in-dependencies/package.json‎`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"dependencies": {`
`3`	`3`	`"postcss":"^8.0.0"`
`4`		`- },`
`5`		`-"devDependencies": {}`
`6`		`-}`
	`4`	`+ }`
	`5`	`+}`

`‎test/fixtures/package-json-files/postcss-v8-in-devDependencies/package.json‎`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`{`
`2`		`-"dependencies": {},`
`3`	`2`	`"devDependencies": {`
`4`	`3`	`"postcss":"^8.0.0"`
`5`	`4`	`}`
`6`		`-}`
	`5`	`+}`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp