Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Refactor output-format related code into a dedicated class + interface#88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mpdude merged 9 commits intomasterfrom145919-refactor-dumper
Aug 30, 2022

Conversation

@FabianSchmick
Copy link
Member

@FabianSchmickFabianSchmick commentedMay 31, 2022•
edited by mpdude
Loading

We are looking into adding an option to do CSV exports as well. As a first step in that direction, we need to separate everything related to how we write export SQL from things related to fetching the data and user interface. Currently, that's all mixed up in theDumper class.

This PR takes a first step in that direction by introducing theOutputFormatDriverInterface, and moving everything related to exporting SQL from theDumper class toMysqlOutputFormatDriver.

Copy link
Member

@mpdudempdude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Heading in a good direction already!

@mpdudempdude mentioned this pull requestAug 29, 2022
mpdude added a commit that referenced this pull requestAug 29, 2022
The `DumperTest` class is FUBAR in its design: It mocks the DBAL connection, making assumptions about the order and semantics of the queries the `Dumper` class will issue.As long as we need to query the database for schema information and/or use the DBAL schema tool that does it, probably the only way to go for code like this is to do real functional/integration tests against a real database.Since this broken test is getting in our way in#88, let's remove it.
…s by preferring passing Schema Asset objects (#89)This PR tweaks the new `SqlDumper` class from#88 a bit and introduces a dedicated interface for it. Also, it prefers using the Schema Tool API instead of passing around an array of column names.
@mpdudempdude marked this pull request as ready for reviewAugust 29, 2022 21:48
@mpdudempdude changed the titleCreate a stub for an "SqlDumper" (Case 145919)Refactor output-format related code into a dedicated class + interfaceAug 30, 2022
@mpdudempdude merged commitfb2d7af intomasterAug 30, 2022
@mpdudempdude deleted the 145919-refactor-dumper branchAugust 30, 2022 08:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mpdudempdudempdude approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FabianSchmick@mpdude
[8]ページ先頭
©2009-2025 Movatter.jp