- Notifications
You must be signed in to change notification settings - Fork490
feat: adding support for WebSocket#714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:develop-4.0
Are you sure you want to change the base?
feat: adding support for WebSocket#714
Uh oh!
There was an error while loading.Please reload this page.
Conversation
yaroslavyaroslav commentedJan 9, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It could be missed in the rush, so I just refresh it: why do we consider adding websocket as 4.0 feature rather then minor update for the 3.* one@JeneaVranceanu? |
JeneaVranceanu commentedJan 10, 2023
@yaroslavyaroslav I think we will have to change the way we store and manage |
yaroslavyaroslav commentedJan 10, 2023
@JeneaVranceanu I'm really curious why the WebSocket will lead to changes that you've mentioned. Looking forward to hear from you, no rushing tho. |
Uh oh!
There was an error while loading.Please reload this page.
WARNING: It's a WIP. If you wish to you can review the PR but it's not finished yet.
Summary of Changes
Adds support for WebSockets that will be part of 4.0 release.
DefaultWeb3SocketClientwas added and is based on the nativeURLSessionWebSocketTask. It's wrapped in#if !os(Linux) ... #endifso we can add a separate instance ofDefaultWeb3SocketClientfor Linux based on some other library that supports Linux.Issues that are left to resolve/add:
attachedKeystoreto theweb3class;Test Data or Screenshots
empty
By submitting this pull request, you are confirming the following:
developbranch.