Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: adding support for WebSocket#714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
JeneaVranceanu wants to merge36 commits intoweb3swift-team:develop-4.0
base:develop-4.0
Choose a base branch
Loading
fromJeneaVranceanu:feat/webscoket-support

Conversation

@JeneaVranceanu
Copy link
Collaborator

@JeneaVranceanuJeneaVranceanu commentedDec 20, 2022
edited
Loading

WARNING: It's a WIP. If you wish to you can review the PR but it's not finished yet.

Summary of Changes

Adds support for WebSockets that will be part of 4.0 release.

DefaultWeb3SocketClient was added and is based on the nativeURLSessionWebSocketTask. It's wrapped in#if !os(Linux) ... #endif so we can add a separate instance ofDefaultWeb3SocketClient for Linux based on some other library that supports Linux.

Issues that are left to resolve/add:

Test Data or Screenshots

empty

By submitting this pull request, you are confirming the following:
  • I have reviewed theContribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match thedevelop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@JeneaVranceanuJeneaVranceanu added enhancementNew feature or request 4.0 labelsDec 20, 2022
@JeneaVranceanuJeneaVranceanu self-assigned thisDec 20, 2022
@JeneaVranceanuJeneaVranceanu changed the base branch fromdevelop todevelop-4.0December 20, 2022 09:33
@yaroslavyaroslav
Copy link
Collaborator

yaroslavyaroslav commentedJan 9, 2023
edited
Loading

It could be missed in the rush, so I just refresh it: why do we consider adding websocket as 4.0 feature rather then minor update for the 3.* one@JeneaVranceanu?

@JeneaVranceanu
Copy link
CollaboratorAuthor

It could be missed in the rush, so I just refresh it: why do we consider adding websocket as 4.0 feature rather then minor update for the 3.* one@JeneaVranceanu?

@yaroslavyaroslav I think we will have to change the way we store and manageAbstractKeystore in the provider and orWeb3 class. It's not yet completely decided. I'm going to focus on that in the following days as I'm back from holidays starting this week.

@yaroslavyaroslav
Copy link
Collaborator

@JeneaVranceanu I'm really curious why the WebSocket will lead to changes that you've mentioned. Looking forward to hear from you, no rushing tho.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@JeneaVranceanuJeneaVranceanu

Labels

4.0enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JeneaVranceanu@yaroslavyaroslav@odanylovych

[8]ページ先頭

©2009-2025 Movatter.jp