Avoid updating all animation effects on single animation mutation#485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

suzyh merged 5 commits intoweb-animations:masterfromalancutter:optimiseAnimationMutations

Aug 3, 2016

Merged

Avoid updating all animation effects on single animation mutation#485

suzyh merged 5 commits intoweb-animations:masterfromalancutter:optimiseAnimationMutations

Aug 3, 2016

Conversation

Copy link

Contributor

alancutter commentedAug 2, 2016

This change avoids applying the effects of all Animations when a single Animation's state is modified (e.g. setting currentTime).
This is particularly effective

Performance numbers on Firefox Nightly:
500 calls to element.animate(null, 1000): 1600ms down to 170ms.
The 500 Individual Stars demo (rewritten to use element.animate()): 8.5-9.5s down to 4.5-5s
Test case in#472: 2.5-4s down to 30-50ms

alancutter added5 commits

August 2, 2016 11:46

optimiseAnimationMutations

7218e66

Yay memory management

e5a1e99

Make tests pass

6ff0b69

Don't change tests

242a217

lint

24f7a24

Copy link

Contributor

ewilligers commentedAug 3, 2016

lgtm

suzyh merged commitfbb1a15 intoweb-animations:master

Aug 3, 2016

Copy link

ContributorAuthor

alancutter commentedAug 3, 2016

I discovered afterwards that the quoted performance numbers in the description are a bit bogus. Turns out Firefox's performance is heavily influenced by the developer console being open which I was not accounting for.