- Notifications
You must be signed in to change notification settings - Fork29
Increase Bezier timing function accuracy#428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
alancutter merged 1 commit intoweb-animations:masterfromericwilligers:increase-bezier-accuracyApr 21, 2016
Merged
Increase Bezier timing function accuracy#428
alancutter merged 1 commit intoweb-animations:masterfromericwilligers:increase-bezier-accuracyApr 21, 2016
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
alancutter commentedApr 19, 2016
Test case? |
The polyfill evaluation of cubic Bezier timing functionsgives slightly different results than the native Blinkimplementation.In my testing, this change reduced the absolute error by 63%while only increasing the number of cubic function evaluationsby 31%Thisclosesweb-animations#139
1b2f076 to83c9090CompareContributorAuthor
ericwilligers commentedApr 21, 2016
Test updated. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The polyfill evaluation of cubic Bezier timing functions
gives slightly different results than the native Blink
implementation.
In my testing, this change reduced the absolute error by 63%
while only increasing the number of cubic function evaluations
by 31%
Thiscloses#139