Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Need help i dont understand#229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mh-qureshi wants to merge439 commits intobranch2.0
base:branch2.0
Choose a base branch
Loading
fromdev
Open

Need help i dont understand#229

mh-qureshi wants to merge439 commits intobranch2.0fromdev

Conversation

@mh-qureshi
Copy link

@mh-qureshimh-qureshi commentedJun 20, 2021
edited
Loading

No description provided.

dstocand others added30 commitsMarch 29, 2016 11:01
Property names should be specified using camelCase, for examplebackgroundColor instead of background-color.
Use of hyphens in property names is deprecated
Don't store Javascript functions on AnimationEffectTiming.easing or keyframe.easing
Matrix decomposition: support angle units grad and turn
Remove double call to normalizeTimingInput()
Throw TypeErrors on invalid inputs to AnimationEffectTiming
The polyfill evaluation of cubic Bezier timing functionsgives slightly different results than the native Blinkimplementation.In my testing, this change reduced the absolute error by 63%while only increasing the number of cubic function evaluationsby 31%Thiscloses#139
The object-form-keyframes source file uses a call to Element.animateto decide whether to load the polyfill for the object-form syntax.If the native browser code supports Element.animate without fullsupport for object-form syntax, this test can throw a TypeError (see#72). Inthis case, the polyfill should proceed to load the polyfill. Thispatch implements this behaviour with a try-catch guard around theElement.animate loading check.
In response to review comments, this patch rewrites the test animationin the object-form-keyframes load check, to be more definite that itwill leave the element opacity untouched regardless of the outcome.Since the logic is now not obvious, a lengthy explanatory comment isalso added.
Add try-catch guard to object-form loading check
darrnshnand others added30 commitsJuly 27, 2017 08:22
The property _isFinished is readonly. cancel() should not attempt towrite to the property.resolves#160
We make clear that old Chrome versions are not supported,and mention the option of use a requestAnimationFrame polyfill.
`npm install`was giving the warning`npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2or higher to avoid a RegExp DoS issue`We avoid the warning by using a recent minimatch version.
Do not write to readonly _isFinished
Document that we require requestAnimationFrame
Currently, the semantics of [line 59 in `Gruntfile.js`](https://github.com/web-animations/web-animations-js/blob/ae52749433415fe979396bb82e7e5a0bdf9a115a/Gruntfile.js#L59) is - expose the library as a global called `true`. This causes two problems:1. The wrapping mechanism of uglify breaks in strict mode (more below)2. There's a leaking global variable called `true`The used version of uglify wraps the code in the following construct:```js"(function(" + parameters.join(",") + "){ '$ORIG'; })(" + args.join(",") + ")";```The IIFE passes the global `this` to a function and later tries to set the property name that we've assigned to `wrap`. This works fine in non-strict cases. The only side effect is the global `window.true` that we set to an empty object. In strict mode, however, global `this` equals to `undefined`. We try to set `undefined['true']` which cases a runtime error.We noticed the above scenario after enabling differential loading with `script[type="module"]`, which uses strict mode by default.It'll be fantastic if we can release the fix today, so we don't block the CLI release.Side note, the wrap function of uglify is fixed for strict mode [here](https://github.com/mishoo/UglifyJS2/pull/1811/files#diff-da84828c4bd7834c0040b0bbb51acdec). Maybe update of `grunt` and `grunt-contrib-uglify` is worth it.
Fix the wrapping IIFE of the prod bundle
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

18 participants

@mh-qureshi@dstoc@ericwilligers@alancutter@samthor@suzyh@ewilligers@mival@bedeoverend@filaraujo@dvoytenko@darrnshn@rjwright@foolip@aomarks@mgechev@flackr

[8]ページ先頭

©2009-2025 Movatter.jp