- Notifications
You must be signed in to change notification settings - Fork406
When running on PhantomJS, the Object.defineProperty method doesn't w…#172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ork for every element, prints a log on console and doesn't throw an exception. So now it checks for the change, and forces an exception.
3e609b1 to72b7ed9Compareewilligers commentedNov 4, 2017
Have you signed a Google Contributor License Agreement? This is one of the requirements before we can merge patches. If not, can you test if |
pedrolauro commentedNov 7, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Where do I sign it,@ewilligers ? Can't find where. |
ewilligers commentedNov 8, 2017
pedrolauro commentedNov 8, 2017
I tested with your forked solution, still getting error. CLA signed. |
When running on PhantomJS, the Object.defineProperty method doesn't work for every element, prints a log on console and doesn't throw an exception. So now it checks for the change, and forces an exception.