NotificationsYou must be signed in to change notification settings
Fork57
Star747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

[fix] remove rfkill switch support#254

Open

aadilshabier wants to merge1 commit intowaycrate:main

base:main

Choose a base branch

fromaadilshabier:rfkill_purge

Open

[fix] remove rfkill switch support#254

aadilshabier wants to merge1 commit intowaycrate:mainfromaadilshabier:rfkill_purge

Conversation

Copy link

Contributor

aadilshabier commentedMar 10, 2024•
edited
Loading

Fix#174

The previous fix(0af3d0d) of disabling rfkill-input does not work anymore, this results in the wifi device turning off when starting swhkd.

[fix] remove rfkill switch support

632b0a4

The previous fix(0af3d0d) of disabling rfkill-input does not work anymore, this results in the wifi device turning off when starting swhkd.

aadilshabier force-pushed therfkill_purge branch from471eb4d to632b0a4Compare

March 10, 2024 18:07

aadilshabier changed the title~~[fix] remove rfkill switch support (#174)~~[fix] remove rfkill switch support

Mar 10, 2024

Shinyzenith approved these changes

Mar 23, 2024

View reviewed changes

Copy link

Member

Shinyzenith commentedMar 23, 2024

CC:@zubairmh Thoughts?

zubairmh approved these changes

Apr 1, 2024

View reviewed changes

Copy link

id3v1669 commentedApr 3, 2024•
edited
Loading

CC:@zubairmh Thoughts?

Maybe it's better to make itoptional to keep support for distros that need it?

Copy link

zubairmh commentedApr 3, 2024•
edited
Loading

CC:@zubairmh Thoughts?
Maybe it's better to make itoptional to keep support for distros that need it?

Most distro's seem to be unaffected, if someone is able to confirm that their distro is affected then it might be considerable.

It also seems inconsistent to have rfkill switch support for one distro and not for others

Copy link

Member

Shinyzenith commentedApr 6, 2024

Artix, Arch and Fedora are from my experience, affected. Since most of the major distros are facing issues due to the previous changes, I would like to see this merged.

Does that sound acceptable? CC:@id3v1669

Copy link

id3v1669 commentedApr 7, 2024•
edited
Loading

Artix, Arch and Fedora are from my experience, affected. Since most of the major distros are facing issues due to the previous changes, I would like to see this merged.
Does that sound acceptable? CC:@id3v1669

Just tested on 5 distros:

Distro	wifi dies with rfkill	wifi dies without rfkill
Opensuse(Tumbleweed)	+	+
NixOS(unstable)	-	+
NixOS(unstable)	*	-
Debian 12	-	+
Alpine	*	-

* doesn't work with rfkill at all

If your tests show that other distros are not affected by removing rfkill, it's ok to merge.
In rare cases, the patch can be applied during packaging.

Copy link

ContributorAuthor

aadilshabier commentedApr 15, 2024

Hey,@id3v1669
I'm having trouble understanding the table. Does the second column mean that wifi dies even after removingSW_RFKILL_ALL from the list of switches?

Copy link

id3v1669 commentedApr 16, 2024•
edited
Loading

Hey,@id3v1669 I'm having trouble understanding the table. Does the second column mean that wifi dies even after removingSW_RFKILL_ALL from the list of switches?

Yes, second column mean that wifi dies even after removingSW_RFKILL_ALL .
No idea why that is happening, but on different devices I've got different behavior with same configuration.
This table works for Thinkpad L14 Gen 3 with intel AX210/AX1675 wifi module.
On Intel Nuc 11 PH with intel AX201 behavior is different and results are not in table.