- Notifications
You must be signed in to change notification settings - Fork211
Commit59d550b
committed
Make object-valued user prompt handler defaults always override
Previously an object value for the unhandledPromptBehavior capabilitylike:{ "default": "dismiss"}was equivalent to the string value"dismiss"which for legacy reasons does not affect "beforeUnload" prompts.For WebDriver-BiDi session we'd ideally like to remove this specialcase and have the default value apply to all prompt types.Therefore this changes things so that an object value with a defaultkey provides a default that applies to all prompt types, whereas thetraditional string values only apply to alert/confirm/prompt dialogs.This preserves classic semantics for string-only values, but makes theobject values behave in a more uniform way.1 parent549d8aa commit59d550b
1 file changed
+13
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10481 | 10481 | | |
10482 | 10482 | | |
10483 | 10483 | | |
| 10484 | + | |
| 10485 | + | |
10484 | 10486 | | |
10485 | | - | |
| 10487 | + | |
| 10488 | + | |
10486 | 10489 | | |
10487 | 10490 | | |
10488 | 10491 | | |
| |||
10492 | 10495 | | |
10493 | 10496 | | |
10494 | 10497 | | |
10495 | | - | |
10496 | | - | |
10497 | | - | |
| 10498 | + | |
| 10499 | + | |
| 10500 | + | |
10498 | 10501 | | |
10499 | 10502 | | |
10500 | 10503 | | |
| |||
10584 | 10587 | | |
10585 | 10588 | | |
10586 | 10589 | | |
10587 | | - | |
| 10590 | + | |
10588 | 10591 | | |
10589 | | - | |
| 10592 | + | |
10590 | 10593 | | |
10591 | 10594 | | |
10592 | 10595 | | |
| |||
10623 | 10626 | | |
10624 | 10627 | | |
10625 | 10628 | | |
| 10629 | + | |
| 10630 | + | |
| 10631 | + | |
10626 | 10632 | | |
10627 | 10633 | | |
10628 | 10634 | | |
10629 | 10635 | | |
10630 | 10636 | | |
10631 | | - | |
| 10637 | + | |
10632 | 10638 | | |
10633 | 10639 | | |
10634 | 10640 | | |
| |||
0 commit comments
Comments
(0)