- Notifications
You must be signed in to change notification settings - Fork3.4k
[import.meta.url] Implement import.meta.url behind flag (Blink-side)#7888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
wpt-pr-bot approved these changesOct 18, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Already reviewed downstream.
ghost commentedOct 19, 2017 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
Build PASSEDStarted: 2017-10-24 01:34:49 View more information about this build on: |
35182ab
to8de7fd3
Compare5 tasks
7942168
to80b3df6
CompareThis CL implementshttps://html.spec.whatwg.org/#hostgetimportmetapropertiesas HostGetImportMetaProperties() in V8Initializer.cpp and Modulator,and thus enables import.meta.url behind the flag added inhttps://chromium-review.googlesource.com/c/chromium/src/+/727179.This CL also adds a layout test, and sets up virtual test for that.Bug: 773713Change-Id: I1d28123f803095535ed9a0208587e1dd873376cbReviewed-on:https://chromium-review.googlesource.com/726525Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>Reviewed-by: Kouhei Ueno <kouhei@chromium.org>Cr-Commit-Position: refs/heads/master@{#510988}
80b3df6
to0ad3d11
Compareservo-wpt-sync pushed a commit to servo-wpt-sync/web-platform-tests that referenced this pull requestAug 4, 2023
This change replaces OpenSSL with rustls and also the manually curatedCA certs file with webpki-roots (effectively the same thing, but as acrate).Generally speaking the design of the network stack is the same. Changes:- Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager`- hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code.- The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later.- Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots).- Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2]1.https://wiki.mozilla.org/Security/Server_Side_TLS2.https://github.com/briansmith/webpki/issues/114Fixesweb-platform-tests#7888.Fixesweb-platform-tests#13749.Fixesweb-platform-tests#26835.Fixesweb-platform-tests#29291.
servo-wpt-sync pushed a commit to servo-wpt-sync/web-platform-tests that referenced this pull requestAug 4, 2023
This change replaces OpenSSL with rustls and also the manually curatedCA certs file with webpki-roots (effectively the same thing, but as acrate).Generally speaking the design of the network stack is the same. Changes:- Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager`- hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code.- The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later.- Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots).- Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2]1.https://wiki.mozilla.org/Security/Server_Side_TLS2.https://github.com/briansmith/webpki/issues/114Fixesweb-platform-tests#7888.Fixesweb-platform-tests#13749.Fixesweb-platform-tests#26835.Fixesweb-platform-tests#29291.
servo-wpt-sync pushed a commit to servo-wpt-sync/web-platform-tests that referenced this pull requestAug 7, 2023
This change replaces OpenSSL with rustls and also the manually curatedCA certs file with webpki-roots (effectively the same thing, but as acrate).Generally speaking the design of the network stack is the same. Changes:- Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager`- hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code.- The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later.- Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots).- Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2]1.https://wiki.mozilla.org/Security/Server_Side_TLS2.https://github.com/briansmith/webpki/issues/114Fixesweb-platform-tests#7888.Fixesweb-platform-tests#13749.Fixesweb-platform-tests#26835.Fixesweb-platform-tests#29291.
servo-wpt-sync pushed a commit to servo-wpt-sync/web-platform-tests that referenced this pull requestAug 8, 2023
This change replaces OpenSSL with rustls and also the manually curatedCA certs file with webpki-roots (effectively the same thing, but as acrate).Generally speaking the design of the network stack is the same. Changes:- Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager`- hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code.- The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later.- Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots).- Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2]1.https://wiki.mozilla.org/Security/Server_Side_TLS2.https://github.com/briansmith/webpki/issues/114Fixesweb-platform-tests#7888.Fixesweb-platform-tests#13749.Fixesweb-platform-tests#26835.Fixesweb-platform-tests#29291.
servo-wpt-sync pushed a commit to servo-wpt-sync/web-platform-tests that referenced this pull requestAug 8, 2023
This change replaces OpenSSL with rustls and also the manually curatedCA certs file with webpki-roots (effectively the same thing, but as acrate).Generally speaking the design of the network stack is the same. Changes:- Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager`- hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code.- The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later.- Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots).- Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2]1.https://wiki.mozilla.org/Security/Server_Side_TLS2.https://github.com/briansmith/webpki/issues/114Fixesweb-platform-tests#7888.Fixesweb-platform-tests#13749.Fixesweb-platform-tests#26835.Fixesweb-platform-tests#29291.
servo-wpt-sync pushed a commit that referenced this pull requestAug 8, 2023
This change replaces OpenSSL with rustls and also the manually curatedCA certs file with webpki-roots (effectively the same thing, but as acrate).Generally speaking the design of the network stack is the same. Changes:- Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager`- hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code.- The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later.- Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots).- Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2]1.https://wiki.mozilla.org/Security/Server_Side_TLS2.https://github.com/briansmith/webpki/issues/114Fixes#7888.Fixes#13749.Fixes#26835.Fixes#29291.
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this pull requestDec 11, 2023
This change replaces OpenSSL with rustls and also the manually curatedCA certs file with webpki-roots (effectively the same thing, but as acrate).Generally speaking the design of the network stack is the same. Changes:- Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager`- hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code.- The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later.- Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots).- Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2]1.https://wiki.mozilla.org/Security/Server_Side_TLS2.https://github.com/briansmith/webpki/issues/114Fixesweb-platform-tests#7888.Fixesweb-platform-tests#13749.Fixesweb-platform-tests#26835.Fixesweb-platform-tests#29291.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This CL implements
https://html.spec.whatwg.org/#hostgetimportmetaproperties
as HostGetImportMetaProperties() in V8Initializer.cpp and Modulator,
and thus enables import.meta.url behind the flag added in
https://chromium-review.googlesource.com/c/chromium/src/+/727179.
This CL also adds a layout test, and sets up virtual test for that.
Bug: 773713
Change-Id: I1d28123f803095535ed9a0208587e1dd873376cb
Reviewed-on:https://chromium-review.googlesource.com/726525
Commit-Queue: Hiroshige Hayashizakihiroshige@chromium.org
Reviewed-by: Kouhei Uenokouhei@chromium.org
Cr-Commit-Position: refs/heads/master@{#510988}