- Notifications
You must be signed in to change notification settings - Fork40
Ignore a URL with an unsupported scheme#447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
tidoust pushed a commit to web-platform-tests/wpt that referenced this pull requestMar 16, 2018
…ed (#9966)Completes `PresentationRequest` constructor test with change [latest change made in Presentation API](w3c/presentation-api#447). The following tests are added:- To check if an instance of `PresentationRequest` with URLs including one with an unsupported scheme is successfully constructed- To check if `NotSupportedError` is thrown when only single or multiple URLs with unsupported schemes are specified
Contributor
markafoltz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the PR. One editorial suggestion.
index.html Outdated
| <li>Resolve<var>U</var> relative to the API base URL specified | ||
| by the<a>current settings object</a>, and add the resulting | ||
| absolute URL (if any) to<var>presentationUrls</var>. | ||
| absolute URL (if any, and if the resulting scheme is supported |
Contributor
markafoltzMar 22, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This might be easier to read if it were broken into three steps. Here is one way that could be done.
- Let A be absolute URL that is the result of resolvingU relative to the API base URL specified by the current settings object.
- If the parse a URL algorithm failed, then throw a SyntaxError exception and abort all remaining steps.
- If A has a scheme supported by the controlling user agent, add A to presentationUrls.
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Thanks for your suggestion.
ContributorAuthor
tomoyukilabs commentedMar 26, 2018
@mfoltzgoogle PTAL |
markafoltz approved these changesMar 26, 2018
Contributor
markafoltz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM with one minor typo
| <li>Resolve<var>U</var>relative to the API base URL specified | ||
| by the<a>current settings object</a>, and add theresulting | ||
| absolute URL (if any) to<var>presentationUrls</var>. | ||
| <li>let<var>A</var>be an absolute URL that is the result of |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nit: s/let/Let/
Contributor
markafoltz commentedMar 26, 2018
Merging, can fix the typo in a followup commit. |
ContributorAuthor
tomoyukilabs commentedMar 27, 2018
@mfoltzgoogle Many thanks for your review and fixing the typo. |
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull requestApr 15, 2018
… unsupported scheme is ignored, a=testonlyAutomatic update from web-platform-tests[presentation-api] check if a URL with an unsupported scheme is ignored (#9966)Completes `PresentationRequest` constructor test with change [latest change made in Presentation API](w3c/presentation-api#447). The following tests are added:- To check if an instance of `PresentationRequest` with URLs including one with an unsupported scheme is successfully constructed- To check if `NotSupportedError` is thrown when only single or multiple URLs with unsupported schemes are specifiedwpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3wpt-pr: 9966wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3wpt-pr: 9966
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull requestOct 2, 2019
… unsupported scheme is ignored, a=testonlyAutomatic update from web-platform-tests[presentation-api] check if a URL with an unsupported scheme is ignored (#9966)Completes `PresentationRequest` constructor test with change [latest change made in Presentation API](w3c/presentation-api#447). The following tests are added:- To check if an instance of `PresentationRequest` with URLs including one with an unsupported scheme is successfully constructed- To check if `NotSupportedError` is thrown when only single or multiple URLs with unsupported schemes are specifiedwpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3wpt-pr: 9966wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3wpt-pr: 9966UltraBlame original commit: 7b6feb16ae6fe5ee0889b819b649b2b41e003893
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull requestOct 2, 2019
… unsupported scheme is ignored, a=testonlyAutomatic update from web-platform-tests[presentation-api] check if a URL with an unsupported scheme is ignored (#9966)Completes `PresentationRequest` constructor test with change [latest change made in Presentation API](w3c/presentation-api#447). The following tests are added:- To check if an instance of `PresentationRequest` with URLs including one with an unsupported scheme is successfully constructed- To check if `NotSupportedError` is thrown when only single or multiple URLs with unsupported schemes are specifiedwpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3wpt-pr: 9966wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3wpt-pr: 9966UltraBlame original commit: 7b6feb16ae6fe5ee0889b819b649b2b41e003893
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull requestOct 2, 2019
… unsupported scheme is ignored, a=testonlyAutomatic update from web-platform-tests[presentation-api] check if a URL with an unsupported scheme is ignored (#9966)Completes `PresentationRequest` constructor test with change [latest change made in Presentation API](w3c/presentation-api#447). The following tests are added:- To check if an instance of `PresentationRequest` with URLs including one with an unsupported scheme is successfully constructed- To check if `NotSupportedError` is thrown when only single or multiple URLs with unsupported schemes are specifiedwpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3wpt-pr: 9966wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3wpt-pr: 9966UltraBlame original commit: 7b6feb16ae6fe5ee0889b819b649b2b41e003893
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull requestSep 16, 2025
… unsupported scheme is ignored, a=testonlyAutomatic update from web-platform-tests[presentation-api] check if a URL with an unsupported scheme is ignored (#9966)Completes `PresentationRequest` constructor test with change [latest change made in Presentation API](w3c/presentation-api#447). The following tests are added:- To check if an instance of `PresentationRequest` with URLs including one with an unsupported scheme is successfully constructed- To check if `NotSupportedError` is thrown when only single or multiple URLs with unsupported schemes are specifiedwpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3wpt-pr: 9966wpt-commits: 1cbb9282ad842c48fff8a86e121ce7e33f6ca4a3wpt-pr: 9966
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR addresses#446.
Preview |Diff