Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix ReSpec warnings#441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
anssiko merged 1 commit intogh-pagesfromfix-respec-warnings
Oct 10, 2017
Merged

Fix ReSpec warnings#441

anssiko merged 1 commit intogh-pagesfromfix-respec-warnings
Oct 10, 2017

Conversation

@anssiko
Copy link
Member

@anssikoanssiko commentedOct 10, 2017
edited by pr-previewbot
Loading

A recent ReSpec update has introduced 109 ReSpec warnings, see the top-right corner of theEditor's Draft. This PR fixes all these warnings, see theHTML preview of the spec with the following editorial fixes applied:

Global <a for> -> <a data-link-for>Global <dfn lt> -> <dfn data-lt>Add <dfn>presentation displays</dfn>Add <ol data-link-for="PresentationAvailability">Add <ol data-link-for="PresentationConnection">Add <section data-dfn-for="Navigator" data-link-for="Navigator"><dfn for="Navigator"><code>presentation</code></dfn> -><a data-link-for="Navigator"><code>presentation</code></a>instance of the <a><code>Presentation</code></a> ->instance of the <a data-link-for="Presentation">Presentation</a>

PTAL @mfoltzgoogle

For the record, this PR fixes the following warnings:

No <dfn> for interface Presentation. More info.No <dfn> for interface Presentation. More info.No <dfn> for interface Presentation. More info.Found linkless element with text 'presentation displays' but no matching <dfn>.Found linkless element with text 'controller' but no matching <dfn>.Found linkless element with text 'controller' but no matching <dfn>.Found linkless element with text 'controller' but no matching <dfn>.Found linkless element with text 'presentation displays' but no matching <dfn>.Found linkless element with text 'presentation displays' but no matching <dfn>.Found linkless element with text 'start' but no matching <dfn>.Found linkless element with text 'reconnect' but no matching <dfn>.Found linkless element with text 'presentation connections' but no matching <dfn>.Found linkless element with text 'controlling browsing contexts' but no matching <dfn>.Found linkless element with text 'presentation connections' but no matching <dfn>.Found linkless element with text 'presentation connections' but no matching <dfn>.Found linkless element with text 'presentation connections' but no matching <dfn>.Found linkless element with text 'presentation connections' but no matching <dfn>.Found linkless element with text 'defaultrequest' but no matching <dfn>.Found linkless element with text 'start' but no matching <dfn>.Found linkless element with text 'start' but no matching <dfn>.Found linkless element with text 'presentation identifiers' but no matching <dfn>.Found linkless element with text 'presentation connections' but no matching <dfn>.Found linkless element with text 'connecting' but no matching <dfn>.Found linkless element with text 'connection' but no matching <dfn>.Found linkless element with text 'error' but no matching <dfn>.Found linkless element with text 'reconnect' but no matching <dfn>.Found linkless element with text 'terminated' but no matching <dfn>.Found linkless element with text 'connecting' but no matching <dfn>.Found linkless element with text 'connected' but no matching <dfn>.Found linkless element with text 'connecting' but no matching <dfn>.Found linkless element with text 'terminated' but no matching <dfn>.Found linkless element with text 'connecting' but no matching <dfn>.Found linkless element with text 'connection' but no matching <dfn>.Found linkless element with text 'start' but no matching <dfn>.Found linkless element with text 'getavailability' but no matching <dfn>.Found linkless element with text 'getavailability' but no matching <dfn>.Found linkless element with text 'presentation displays' but no matching <dfn>.Found linkless element with text 'value' but no matching <dfn>.Found linkless element with text 'getavailability' but no matching <dfn>.Found linkless element with text 'presentation displays' but no matching <dfn>.Found linkless element with text 'presentation displays' but no matching <dfn>.Found linkless element with text 'getavailability' but no matching <dfn>.Found linkless element with text 'getavailability' but no matching <dfn>.Found linkless element with text 'presentation displays' but no matching <dfn>.Found linkless element with text 'presentation displays' but no matching <dfn>.Found linkless element with text 'value' but no matching <dfn>.Found linkless element with text 'value' but no matching <dfn>.Found linkless element with text 'value' but no matching <dfn>.Found linkless element with text 'value' but no matching <dfn>.Found linkless element with text 'start' but no matching <dfn>.Found linkless element with text 'getavailability' but no matching <dfn>.Found linkless element with text 'presentation displays' but no matching <dfn>.Found linkless element with text 'connection' but no matching <dfn>.Found linkless element with text 'controller' but no matching <dfn>.Found linkless element with text 'controller' but no matching <dfn>.Found linkless element with text 'start' but no matching <dfn>.Found linkless element with text 'reconnect' but no matching <dfn>.Found linkless element with text 'defaultrequest' but no matching <dfn>.Found linkless element with text 'connection' but no matching <dfn>.Found linkless element with text 'connection' but no matching <dfn>.Found linkless element with text 'reconnect' but no matching <dfn>.Found linkless element with text 'closed' but no matching <dfn>.Found linkless element with text 'connecting' but no matching <dfn>.Found linkless element with text 'connected' but no matching <dfn>.Found linkless element with text 'wentaway' but no matching <dfn>.Found linkless element with text 'closed' but no matching <dfn>.Found linkless element with text 'wentaway' but no matching <dfn>.Found linkless element with text 'connecting' but no matching <dfn>.Found linkless element with text 'connected' but no matching <dfn>.Found linkless element with text 'error' but no matching <dfn>.Found linkless element with text 'send' but no matching <dfn>.Found linkless element with text 'state' but no matching <dfn>.Found linkless element with text 'connected' but no matching <dfn>.Found linkless element with text 'error' but no matching <dfn>.Found linkless element with text 'state' but no matching <dfn>.Found linkless element with text 'connected' but no matching <dfn>.Found linkless element with text 'error' but no matching <dfn>.Found linkless element with text 'closed' but no matching <dfn>.Found linkless element with text 'reason' but no matching <dfn>.Found linkless element with text 'error' but no matching <dfn>.Found linkless element with text 'reason' but no matching <dfn>.Found linkless element with text 'connecting' but no matching <dfn>.Found linkless element with text 'connected' but no matching <dfn>.Found linkless element with text 'closed' but no matching <dfn>.Found linkless element with text 'wentaway' but no matching <dfn>.Found linkless element with text 'connecting' but no matching <dfn>.Found linkless element with text 'connected' but no matching <dfn>.Found linkless element with text 'closed' but no matching <dfn>.Found linkless element with text 'closed' but no matching <dfn>.Found linkless element with text 'closed' but no matching <dfn>.Found linkless element with text 'reason' but no matching <dfn>.Found linkless element with text 'connected' but no matching <dfn>.Found linkless element with text 'connecting' but no matching <dfn>.Found linkless element with text 'connected' but no matching <dfn>.Found linkless element with text 'connecting' but no matching <dfn>.Found linkless element with text 'terminated' but no matching <dfn>.Found linkless element with text 'connected' but no matching <dfn>.Found linkless element with text 'terminated' but no matching <dfn>.Found linkless element with text 'connected' but no matching <dfn>.Found linkless element with text 'connecting' but no matching <dfn>.Found linkless element with text 'terminated' but no matching <dfn>.Found linkless element with text 'presentation connections' but no matching <dfn>.Found linkless element with text 'controlling browsing contexts' but no matching <dfn>.Found linkless element with text 'connected' but no matching <dfn>.Found linkless element with text 'closed' but no matching <dfn>.Found linkless element with text 'connection' but no matching <dfn>.Found linkless element with text 'reconnect' but no matching <dfn>.Found linkless element with text 'send' but no matching <dfn>.Found linkless element with text 'presentation connections' but no matching <dfn>.

Preview |Diff

Specific changes:Global <a for> -> <a data-link-for>Global <dfn lt> -> <dfn data-lt>Add <dfn>presentation displays</dfn>Add <ol data-link-for="PresentationAvailability">Add <ol data-link-for="PresentationConnection">Add <section data-dfn-for="Navigator" data-link-for="Navigator"><dfn for="Navigator"><code>presentation</code></dfn> -><a data-link-for="Navigator"><code>presentation</code></a>instance of the <a><code>Presentation</code></a> ->instance of the <a data-link-for="Presentation">Presentation</a>
@markafoltz
Copy link
Contributor

LGTM

It doesn't bode well for this document as a living standard if ReSpec will continue to push changes that break it.

@anssiko
Copy link
MemberAuthor

True, but to be fair, many of the warnings were caused by the use of non-standard attributes, like those fixed by data-*. I’m not expecting more such breaking changes.

@anssikoanssiko merged commitb29f405 intogh-pagesOct 10, 2017
@anssikoanssiko deleted the fix-respec-warnings branchOctober 10, 2017 17:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anssiko@markafoltz

[8]ページ先頭

©2009-2025 Movatter.jp