- Notifications
You must be signed in to change notification settings - Fork40
Clarify self-navigation behavior in a presentation.#461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
markafoltz commentedApr 4, 2019
PTAL@tidoust as you filed the original issue :-) |
index.html Outdated
| navigate</a>, it SHOULD NOT offer to open the resource in a new | ||
| <a>top-level browsing context</a>, but instead SHOULD abort the | ||
| navigation and possibly throw a<a>SecurityError</a> (consistent | ||
| with the<a>steps to navigate</a>). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That is not entirely "consistent" with the steps to navigate: the steps to navigate in HTML mandate theSecurityError be thrown when theexceptions enabled flag is set, whereas this makes it optional.
If theSecurityError exception cannot be mandated because it remains a challenge implementation-wise, I would suggest to drop "(consistent with the steps to navigate)".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Throwing the exception isn't an implementation concern from my point of view. Rather I didn't want to get into the details here of when to throw aSecurityError and thus duplicate HTML. I rephrased this, let me know if that addresses your feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, looks good!
markafoltz commentedApr 5, 2019
Thanks! |
Uh oh!
There was an error while loading.Please reload this page.
This addresses feedback in Issue#455, to link navigation behavior to the HTML 5.1 navigation steps, and clarify how the receiving user agent should respond.
There's also a bunch of changes from attempting to run tidy-html5 which I'll clean up in another commit on this PR.
Preview |Diff