Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add explanatory text to examples.#460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
markafoltz merged 4 commits intogh-pagesfromissue-435-examples
Apr 1, 2019
Merged

Conversation

@markafoltz
Copy link
Contributor

@markafoltzmarkafoltz commentedMar 26, 2019•
edited by pr-previewbot
Loading

This addresses Issue#435, by adding a brief explanation before each section of example code. It would be helpful for a second pair of eyes to point out anything that is still not obvious and could be improved.

It also addresses some ReSpec errors that have crept in, apparently because event names are not defined in WebIDL, and also conflict with function definitions. We'll just leave them unlinked for simplicity.

Preview |Diff

@markafoltz
Copy link
ContributorAuthor

PTAL@chrisn as you submitted the original issue.

@chrisn
Copy link
Member

Thanks for the reminder, will do!

Copy link
Member

@chrisnchrisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@mfoltzgoogle Many thanks for this. I have left a few comments for your consideration.

@markafoltzmarkafoltz merged commitff5a520 intogh-pagesApr 1, 2019
@markafoltzmarkafoltz deleted the issue-435-examples branchApril 1, 2019 23:11
@markafoltz
Copy link
ContributorAuthor

Thanks for all the comments@chrisn, I applied them to the PR and merged.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chrisnchrisnchrisn requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markafoltz@chrisn
[8]ページ先頭
©2009-2025 Movatter.jp