Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Addselectedcontent element and allowances for 'button' part of select#528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
patrickhlauke merged 14 commits intow3c:gh-pagesfromjosepharhar:selectedoption
Jul 23, 2025

Conversation

@josepharhar
Copy link
Contributor

@josepharharjosepharhar commentedSep 27, 2024
edited by pr-previewbot
Loading

The<selectedoption> element is part of thecustomizable select feature and is being added to HTMLhere.

It is already implemented in chromium and will be shipped when customizable<select> is shipped.

test case


Preview |Diff

@scottaohara
Copy link
Member

Noting here that there will need to be an entry for abutton as a child of aselect as well.

@josepharhar
Copy link
ContributorAuthor

Noting here that there will need to be an entry for a button as a child of a select as well.

Where should I put this?

@josepharharjosepharhar changed the titleAdd<selectedoption> elementAdd<selectedcontent> elementNov 12, 2024
@scottaohara
Copy link
Member

Noting here that there will need to be an entry for a button as a child of a select as well.

Where should I put this?

oh no worries@josepharhar that was a note for me, not so much for you.

if you did want to take it on, we'd need a new button as a child of a select entry in the table - using a similar ID like I'm setting up over in html aamel-button-select-child

but really, don't worry about it. i was planning on working on finishing this PR once the HTML/HTML AAM PRs were a bit closer to done.

josepharhar reacted with heart emoji

@scottaohara
Copy link
Member

latest commit updates selectedcontent to align with recent HTML AAM changes.

also added in the button as a child of select variant / expectations.

@scottaoharascottaohara changed the titleAdd<selectedcontent> elementAddselectedcontent element and allowances for 'button' part of selectMar 26, 2025
account for misuse of element - where the element will just be a generic element and thus is name prohibited, but any role/attributes can be used to modify/fix the errant element, as needed.
@scottaohara
Copy link
Member

test case file created and added to OP -https://w3c.github.io/html-aria/tests/selectedcontent.html

fixed to match other role markup:`<code>role=<a href="#index-aria-generic">generic</a></code>`
Copy link
Member

@patrickhlaukepatrickhlauke left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me (though note one question#528 (comment))

@patrickhlauke
Copy link
Member

discussed with@scottaohara separately. we're ok with the current wording, as the specifics of what a "valid descendant of aselect" is are defined already in HTML, so we can keep it snappy. merging.

@patrickhlaukepatrickhlauke merged commit5aa1657 intow3c:gh-pagesJul 23, 2025
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@scottaoharascottaoharascottaohara left review comments

@patrickhlaukepatrickhlaukepatrickhlauke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@josepharhar@scottaohara@patrickhlauke

[8]ページ先頭

©2009-2025 Movatter.jp