Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

disallow aria-hidden on body element#447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
scottaohara merged 5 commits intogh-pagesfromaria-hidden-body
Mar 6, 2023
Merged

Conversation

@scottaohara
Copy link
Member

@scottaoharascottaohara commentedMar 3, 2023
edited
Loading

related tow3c/aria#1254

closes#221 - there were comments to do more with aria-hidden rules beyond just disallowing it on body, but i'm going to make a new issue for potentially covering those topics.


labels: needs implementation commitment, needs changelog entry


Preview |Diff

related tow3c/aria#1254closes#221 - there were comments to do more with aria-hidden rules beyond just disallowing it on body, but i'm going to make a new issue for potentially covering those topics.
@scottaoharascottaohara added Allowed aria-* attributes needs changelog entryonce 2 implementations land, we can merge and note it in our changelog. labelsMar 3, 2023
as `aria-hidden=false` doesn't seem to cause any problems, even per the note in ARIA to use with caution:>At the time of this writing, aria-hidden="false" is known to work inconsistently in browsers. As future implementations improve, use caution and test thoroughly before relying on this approach.let's limit this rule to just `aria-hidden=true`
@scottaoharascottaohara added Meets 2 implementations reqIndicates that a spec change has met the necessary 2 implementations needed to merge. and removed needs changelog entryonce 2 implementations land, we can merge and note it in our changelog. labelsMar 6, 2023
Copy link
Member

@patrickhlaukepatrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This LGTM, thanks@scottaohara

scottaohara reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@patrickhlaukepatrickhlaukepatrickhlauke approved these changes

Assignees

No one assigned

Labels

Allowed aria-* attributesMeets 2 implementations reqIndicates that a spec change has met the necessary 2 implementations needed to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

disallow aria-hidden on the body element

2 participants

@scottaohara@patrickhlauke

[8]ページ先頭

©2009-2025 Movatter.jp