Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Addition: update figure role allowances#415

Merged
scottaohara merged 9 commits intogh-pagesfrom
issue-412
Feb 13, 2023
Merged

Addition: update figure role allowances#415
scottaohara merged 9 commits intogh-pagesfrom
issue-412

Conversation

@scottaohara
Copy link
Member

@scottaoharascottaohara commentedApr 16, 2022
edited
Loading

closes#412

As discussed inw3c/dpub-aria#42 (comment),doc-example is a dpub variant of thefigure role. This role being the same asfigure but with the opportunity of being exposed as an "example" for its role description, needs to be an allowed role for thefigure element.

createtest case

Expected results:
doc-example is an allowed role for<figure role=doc-example>...<figcaption>...</figcaption>
figure results in a warning as unnecessary for<figure role=figure>...<figcaption>...</figcaption>
no other roles are allowed if afigcaption is a child of afigure element.


Preview |Diff

Seirdy reacted with thumbs up emoji
closes#412As discussed inw3c/dpub-aria#42 (comment), `doc-example` is a dpub variant of the `figure` role.  This role being the same as `figure` but with the opportunity of being exposed as an "example" for its role description, needs to be an allowed role for the `figure` element.
@scottaoharascottaohara added needs implementation commitmentCannot merge into spec until implementations in conformance checkers has been confirmed. needs changelog entryonce 2 implementations land, we can merge and note it in our changelog. labelsApr 16, 2022
@stevefaulknerstevefaulkner self-requested a reviewJuly 13, 2022 12:30
@scottaohara
Copy link
MemberAuthor

merging as arc toolkit and axe do not report errors when using this role on figure element

@scottaoharascottaohara added Meets 2 implementations reqIndicates that a spec change has met the necessary 2 implementations needed to merge. and removed needs implementation commitmentCannot merge into spec until implementations in conformance checkers has been confirmed. needs changelog entryonce 2 implementations land, we can merge and note it in our changelog. labelsFeb 13, 2023
@scottaoharascottaohara merged commit0f29858 intogh-pagesFeb 13, 2023
@scottaoharascottaohara deleted the issue-412 branchFebruary 13, 2023 15:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stevefaulknerstevefaulknerstevefaulkner approved these changes

Assignees

No one assigned

Labels

Meets 2 implementations reqIndicates that a spec change has met the necessary 2 implementations needed to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Correction: allow doc-example role on figure with figcaption

2 participants

@scottaohara@stevefaulkner

Comments


[8]ページ先頭

©2009-2026 Movatter.jp