Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Addition: Prohibit naming of elements#402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
stevefaulkner merged 19 commits intogh-pagesfromissue-147-naming-prohibited
Apr 3, 2022

Conversation

@scottaohara
Copy link
Member

@scottaoharascottaohara commentedFeb 11, 2022•
edited
Loading

Adds new naming requirements section.

Additional work and review needed.
Need to indicate all elements with implicit roles which prohibit naming

closes#147

test case

  • axe largely supports this rule, but for a few elements.

  • w3c validator partially supports this rule, but needs to change warnings to errors, and needs to add a check for aria-labelledby (only checks for aria-label right now)

  • ibm andarc toolkit do not yet support the naming prohibited rule (arc toolkit has implemented this rule)

  • HTML validator

  • IBM equal access accessibility checker

  • axe-core (supported but for 2 elements)

  • ARC toolkit

NOTE: see follow on issue#407 concerning therp element, which has been removed from this PR.

Preview |Diff

Adds new naming requirements section.Additional work and review needed.  Need to indicate all elements with implicit roles which prohibit namingcloses#147
@scottaoharascottaohara added the Do not mergeA PR which needs additional work or question resolved before it can be merged. labelFeb 11, 2022
hardened the code comment
* define elements which are prohibited from being named so long as they expose their implicit semantics* introduce the concepts of prohibited attributes and provide a def for 'naming prohibited' in the spec
@scottaoharascottaohara marked this pull request as ready for reviewFebruary 13, 2022 00:11
@scottaohara
Copy link
MemberAuthor

This PR needs#392 to be merged first. But this is now ready to review.

cc@patrickhlauke@stevefaulkner

@scottaoharascottaohara added blockedAn issue that cannot be resolved due to other external requirements and removed Do not mergeA PR which needs additional work or question resolved before it can be merged. labelsFeb 13, 2022
Copy link
Member

@patrickhlaukepatrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

question there about "from authors" vs "by authors". if the former is used elsewhere, fair enough keep it. but otherwise it would read better as the latter I'd say

@scottaohara
Copy link
MemberAuthor

@patrickhlauke ”name from” is on purpose. It’s what aria says

@patrickhlauke
Copy link
Member

@patrickhlauke ”name from” is on purpose. It’s what aria says

aha, in that case, as awks as it sounds...make it so

@scottaoharascottaohara removed the blockedAn issue that cannot be resolved due to other external requirements labelMar 12, 2022
@scottaoharascottaohara added the Do not mergeA PR which needs additional work or question resolved before it can be merged. labelMar 12, 2022
same rules as caption and label
these either represent their children, per other text-level semantics, or are important in the structure of a `ruby` element.  These shouldn't be named... more testing needed to determine the impact aria can have on these in general.
should push the test to the main branch instead.
@scottaoharascottaohara added needs implementation commitmentCannot merge into spec until implementations in conformance checkers has been confirmed. and removed Do not mergeA PR which needs additional work or question resolved before it can be merged. labelsMar 12, 2022
@scottaoharascottaohara changed the titleProhibit naming of elementsAddition: Prohibit naming of elementsMar 13, 2022
@scottaoharascottaohara added Meets 2 implementations reqIndicates that a spec change has met the necessary 2 implementations needed to merge. and removed needs implementation commitmentCannot merge into spec until implementations in conformance checkers has been confirmed. labelsMar 23, 2022
@stevefaulknerstevefaulkner merged commit59a834c intogh-pagesApr 3, 2022
@stevefaulknerstevefaulkner deleted the issue-147-naming-prohibited branchApril 3, 2022 16:35
scottaohara added a commit that referenced this pull requestMay 19, 2022
directly reference the following PRs in the changelog, and prepend each entry with the appropriate 'label'related to#419-#352-#367 (and follow on [commit](887c772))-#360-#353-#372-#402-#404-#403-#396-#391-#369-#381
estelle pushed a commit to mdn/content that referenced this pull requestOct 14, 2023
* Set implicit role mappings to `generic`Implements changes fromw3c/html-aria#425* Set address' element implicit role to `group`Implements change fromw3c/html-aria@ba30b83* Assign ARIA 1.2 roles to elementsImplements changes fromw3c/html-aria#392* Make `<section>` with inaccessible name's implicit role to be `generic`Seew3c/html-aria#475* Set implicit ARIA mapping for <s> element to `deletion`Seew3c/html-aria#469* Set `form` as the only implicit ARIA role for the form elementSeew3c/html-aria#402
julienw added a commit to julienw/aria-query that referenced this pull requestMar 15, 2024
julienw added a commit to julienw/aria-query that referenced this pull requestMar 15, 2024
julienw added a commit to julienw/dom-accessibility-api that referenced this pull requestMar 15, 2024
julienw added a commit to julienw/aria-query that referenced this pull requestMar 15, 2024
pkra pushed a commit to w3c/aria that referenced this pull requestMay 20, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stevefaulknerstevefaulknerstevefaulkner approved these changes

@patrickhlaukepatrickhlaukepatrickhlauke approved these changes

Assignees

No one assigned

Labels

Meets 2 implementations reqIndicates that a spec change has met the necessary 2 implementations needed to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Note naming certain elements should be prohibited

3 participants

@scottaohara@patrickhlauke@stevefaulkner
[8]ページ先頭
©2009-2025 Movatter.jp