- Notifications
You must be signed in to change notification settings - Fork48
add the new search element#401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
keeping this straight forward for the new element's initial inclusion.being that this is a new element, the reasoning for authors to need to immediately apply overwriting roles is irrelevant. Thus I see no reason to initially allow any roles on this element.All global `aria-*` attributes would be allowed on this element.
7 tasks
domenic commentedMar 24, 2023
@scottaohara we merged the HTML PR, so this should be ready!! |
the additional roles added to the search element allowances are to provide reasonable roles that developers may need to use while the search element is still being implemented by browsers, as well as roles which might be reasonable 'fixes' for someone who used the element per their understanding of its semantics, but was not aware of the landmark region it creates, which is not appropriate in context of their web page.
This was referencedMar 24, 2023
MemberAuthor
scottaohara commentedMar 24, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Conformance checker tracking
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
closes#371
keeping this straight forward for the new element's initial inclusion.
edit: the allowed roles for this element are the following
form,group,none,presentation,regionand with the allowed but not recommended use ofsearch.All global
aria-*attributes would be allowed on this element.As the element is used in the wild, further updates may be necessary for the allowed roles, but these initial allowances should be more than enough for people who immediately misuse the new element and need to correct themselves while somehow also not being able to correct the actual html element.
DONE: update changelog for when the element lands and this PR can be merged into the spec.
Preview |Diff