Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add the new search element#401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
scottaohara merged 10 commits intogh-pagesfromsearch-element-addition
Mar 24, 2023
Merged

Conversation

@scottaohara
Copy link
Member

@scottaoharascottaohara commentedFeb 4, 2022
edited by pr-previewbot
Loading

closes#371

keeping this straight forward for the new element's initial inclusion.

edit: the allowed roles for this element are the following
form,group,none,presentation,region and with the allowed but not recommended use ofsearch.

All globalaria-* attributes would be allowed on this element.

As the element is used in the wild, further updates may be necessary for the allowed roles, but these initial allowances should be more than enough for people who immediately misuse the new element and need to correct themselves while somehow also not being able to correct the actual html element.

DONE: update changelog for when the element lands and this PR can be merged into the spec.


Preview |Diff

keeping this straight forward for the new element's initial inclusion.being that this is a new element, the reasoning for authors to need to immediately apply overwriting roles is irrelevant.  Thus I see no reason to initially allow any roles on this element.All global `aria-*` attributes would be allowed on this element.
@scottaoharascottaohara added the blockedAn issue that cannot be resolved due to other external requirements labelFeb 4, 2022
@domenicdomenic mentioned this pull requestFeb 4, 2022
7 tasks
@scottaoharascottaohara added the needs changelog entryonce 2 implementations land, we can merge and note it in our changelog. labelApr 4, 2022
@domenic
Copy link

@scottaohara we merged the HTML PR, so this should be ready!!

scottaohara reacted with thumbs up emoji

@scottaoharascottaohara removed blockedAn issue that cannot be resolved due to other external requirements needs changelog entryonce 2 implementations land, we can merge and note it in our changelog. labelsMar 24, 2023
the additional roles added to the search element allowances are to provide reasonable roles that developers may need to use while the search element is still being implemented by browsers, as well as roles which might be reasonable 'fixes' for someone who used the element per their understanding of its semantics, but was not aware of the landmark region it creates, which is not appropriate in context of their web page.
@scottaohara
Copy link
MemberAuthor

scottaohara commentedMar 24, 2023
edited
Loading

@scottaoharascottaohara merged commit591be7c intogh-pagesMar 24, 2023
@scottaoharascottaohara deleted the search-element-addition branchMarch 24, 2023 12:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allowances for proposed search element

2 participants

@scottaohara@domenic

[8]ページ先頭

©2009-2025 Movatter.jp