Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Addition: allow aria-hidden on picture element#352

Merged
scottaohara merged 8 commits intogh-pagesfrom
issue-346
Oct 26, 2021
Merged

Addition: allow aria-hidden on picture element#352
scottaohara merged 8 commits intogh-pagesfrom
issue-346

Conversation

@scottaohara
Copy link
Member

@scottaoharascottaohara commentedSep 20, 2021
edited
Loading

Revise the allowances for thepicture element to allow for thearia-hidden attribute.

Need at least two checkers to accept this change before we can merge.

Closes#346


Preview |Diff

Revise the allowances for the `picture` element to allow for the `aria-hidden` attribute.
@scottaoharascottaohara added the needs implementation commitmentCannot merge into spec until implementations in conformance checkers has been confirmed. labelSep 20, 2021
@scottaoharascottaohara added this to theARIA in HTML: Next milestoneSep 20, 2021
@scottaohara

This comment has been minimized.

@scottaoharascottaohara removed this from theARIA in HTML: Next milestoneSep 24, 2021
@scottaoharascottaohara added the Meets 2 implementations reqIndicates that a spec change has met the necessary 2 implementations needed to merge. labelOct 8, 2021
@scottaoharascottaohara removed the needs implementation commitmentCannot merge into spec until implementations in conformance checkers has been confirmed. labelOct 23, 2021
@marcoscaceres
Copy link
Member

Note, you need to do the same for the other pull requests.

I'll review those and make sure it's all good. Feel free to also ping me for review on those.

However, we don't need to wait to merge things into the Editor's draft.

The minute the spec gets published as REC, we can then start pushing all the ".addition" to /TR/.

In the meantime, I've disabled the auto-publish.yml script.

@marcoscaceres
Copy link
Member

Actually, it's a little more nuanced:

https://github.com/w3c/tr-design/blob/e40643f08e80f65a31d54ab2fb9e3ca34fa6cfcc/src/base.css#L35-L38

 *   - .correction for "candidate corrections"       (div, aside, details, section) *   - .addition   for "candidate additions"         (div, aside, details, section) *   - .correction.proposed for "proposed corrections" (div, aside, details, section) *   - .addition.proposed   for "proposed additions"   (div, aside, details, section)

The things in the process are outlined in:
https://www.w3.org/Consortium/Process/Drafts/#revising-rec

scottaoharaand others added2 commitsOctober 26, 2021 11:34
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@scottaoharascottaohara merged commit223bf38 intogh-pagesOct 26, 2021
@scottaoharascottaohara deleted the issue-346 branchOctober 26, 2021 15:38
@scottaoharascottaohara changed the titleallow aria-hidden on picture elementAddition: allow aria-hidden on picture elementMay 19, 2022
scottaohara added a commit that referenced this pull requestMay 19, 2022
directly reference the following PRs in the changelog, and prepend each entry with the appropriate 'label'related to#419-#352-#367 (and follow on [commit](887c772))-#360-#353-#372-#402-#404-#403-#396-#391-#369-#381
pkra pushed a commit to w3c/aria that referenced this pull requestMay 20, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@marcoscaceresmarcoscaceresmarcoscaceres left review comments

+1 more reviewer

@ryanveryanveryanve left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Meets 2 implementations reqIndicates that a spec change has met the necessary 2 implementations needed to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow aria-hidden=true on picture element

3 participants

@scottaohara@marcoscaceres@ryanve

[8]ページ先頭

©2009-2026 Movatter.jp