Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fill in various "?" cells from the element and attribute tables#245

Merged
scottaohara merged 35 commits intogh-pagesfrom
issue_97
Dec 10, 2019
Merged

Fill in various "?" cells from the element and attribute tables#245
scottaohara merged 35 commits intogh-pagesfrom
issue_97

Conversation

@scottaohara
Copy link
Member

@scottaoharascottaohara commentedSep 15, 2019
edited by pr-previewbot
Loading

Closes#97

The following tasks have been completed:

  • Confirmed there are no ReSpec/BikeShed errors or warnings.

Preview |Diff

</div>
</td>
<td class="ax">?</td>
<td class="ax">Not mapped</td>
Copy link
MemberAuthor

@scottaoharascottaoharaSep 16, 2019
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this will be updated further in#226

source is not mappedsrcset on img elements is not mapped, only the baseline src is exposed.
no direct mapping
add note about “not mapped”
* no mappings for sizes on img and source* no mapping for size attribute on input* refer to listbox if size > 1 on select element
potential for this to change in the future per ARIA issue added as inline comment.
should state to use WAI-ARIA mappings
update to use WAI-ARIA mappings
@scottaoharascottaohara marked this pull request as ready for reviewOctober 18, 2019 18:17
@scottaoharascottaohara changed the titleFill in the various "?" cells from the element and attribute tablesFill in various "?" cells from the element and attribute tablesOct 18, 2019
@scottaohara
Copy link
MemberAuthor

outside of ARIA mappings (and even some of those were taken care of in#244 and future work in#259) the attributes table no longer has missing mapping entries.

This PR additionally revises some of the existing mappings to point to Core AAM.

<td class="ia2">
<div class="objattrs">
<span class="type">Object attributes:</span>
`src` on <a href="#el-img">`img`</a> only
Copy link
MemberAuthor

@scottaoharascottaoharaNov 15, 2019
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

see#266

this was incorrectly listed as UIA does not map `src`.closes#266
@scottaohara
Copy link
MemberAuthor

@marcoscaceres can you tell us why this build is failing?

@marcoscaceres
Copy link
Member

Having a look...

@marcoscaceres
Copy link
Member

Some of the scripts are depending on things that we no longer ship with in ReSpec (e.g., RequireJS). I've got a rough patch locally that I'll send up soon that should fix things.

scottaohara reacted with thumbs up emoji

@scottaohara
Copy link
MemberAuthor

@marcoscaceres how'd the patch go? is this safe to merge in regardless of the fail?

@scottaoharascottaohara merged commit5787a05 intogh-pagesDec 10, 2019
@scottaoharascottaohara deleted the issue_97 branchDecember 10, 2019 01:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stevefaulknerstevefaulknerstevefaulkner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AxAPI completion

3 participants

@scottaohara@marcoscaceres@stevefaulkner

Comments


[8]ページ先頭

©2009-2026 Movatter.jp