- Notifications
You must be signed in to change notification settings - Fork730
[pointer-animations-1] Prefixpointer() definition types#12283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Type definitions share a common namespace and the `<axis>` type is alreadydefined in Scroll-driven Animations:https://drafts.csswg.org/scroll-animations-1/#typedef-axisThis update prefixes the `<axis>`, and `<source>` for consistency, typeswith `pointer-` to disambiguate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@tidoust! If I recall correctly I meant to reuseaxis from Scroll-driven Animations, but I'm ok with merging this as is for now, it's still an early ED.
Thesource is probably better off prefixed.
Up to you :) The |
Type definitions share a common namespace and the
<axis>type is already defined in Scroll-driven Animations:https://drafts.csswg.org/scroll-animations-1/#typedef-axis
This update prefixes the
<axis>type (and<source>for consistency) withpointer-to disambiguate. Feel free to adjust the name as you see fit!Note: As in Scroll-driven Animations, the spec defines the types with a
noexportattribute. That seems fine to avoid accidental references from other modules. If that is also meant to create a module-specific namespace for type definitions, we may have a problem as editing tools and validators that I'm aware of and that leverage CSS syntax definitions do not expect that to be possible ;)