- Notifications
You must be signed in to change notification settings - Fork143
Open
Conversation
this PR attempts toclose#2668As mentioned in the referenced issue, authors naming a tooltip either doesn't consistently work with current AT, or it can introduce unintended author errors where if a tooltip is named - and associated with an element via `aria-describedby`, only the name is exposed and not the longer description that a user can see.The reason this changed to name prohibited, is because by removing the 'name from author', only 'name from contents' remained.... and there is no other role in the ARIA spec that allows name from content by itself. All other similar roles are identified as name prohibited.So, while this PR initially only changes the "name from" section from listing "author and contents" to "prohibited" - i assume a note will need to be added to further describe this change and the rational behind it.it might be worth also resolving#2507 in this PR. but before I do that, I will wait for discussion on this initial PR.
netlifybot commentedOct 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview forwai-aria ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the tooltip role definition to prohibit accessible naming, changing the "Name From" characteristic from allowing "contents" and "author" to "prohibited".
- Changed the tooltip role's "Name From" value from a list containing "contents" and "author" to "prohibited"
💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.
Uh oh!
There was an error while loading.Please reload this page.
adampage approved these changesDec 4, 2025
Member
adampage left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ship it. 🚀
Added prohibited states and properties section to the table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
this PR attempts toclose#2668
As mentioned in the referenced issue, authors naming a tooltip either doesn't consistently work with current AT, or it can introduce unintended author errors where if a tooltip is named - and associated with an element via
aria-describedby, only the name is exposed and not the longer description that a user can see.The reason this changed to name prohibited, is because by removing the 'name from author', only 'name from contents' remained.... and there is no other role in the ARIA spec that allows name from content by itself. All other similar roles are identified as name prohibited.
So, while this PR initially only changes the "name from" section from listing "author and contents" to "prohibited" - i assume a note will need to be added to further describe this change and the rational behind it.
it might be worth also resolving#2507 in this PR. but before I do that, I will wait for discussion on this initial PR.
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.
Preview |Diff