feat: add aria-checked support to gridcell and row#2390

Open

smhigley wants to merge 3 commits intomainfrom

gridcell-aria-checked

Open

feat: add aria-checked support to gridcell and row#2390
smhigley wants to merge 3 commits intomainfrom
gridcell-aria-checked

Conversation

Copy link

Contributor

smhigley commentedDec 3, 2024•
edited by pr-previewbot
Loading

Closes#1960

Addsaria-checked as a supported state togridcell, with the same wording around combiningaria-checked &aria-selected as onoption andtreeitem. Thearia-checked support also inherits intocolumnheader androwheader.

Test, Documentation and Implementation tracking

Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.

"author MUST" tests: N/A
"user agent MUST" tests: N/A
Browser implementations (link to issue or commit):
- WebKit:
- Gecko:
- Blink:
Does this need AT implementations? Likely not, since this should come from browser mappings
Related APG Issue/PR: N/A
MDN Issue/PR:

Preview |Diff

smhigley added the spec:aria label

Dec 3, 2024

Copy link

netlifybot commentedDec 3, 2024•
edited
Loading

✅ Deploy Preview forwai-aria ready!

Name	Link
🔨 Latest commit	`632977c`
🔍 Latest deploy log	https://app.netlify.com/sites/wai-aria/deploys/67cb2a207abba40008836728
😎 Deploy Preview	https://deploy-preview-2390--wai-aria.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

jnurthen requested review fromadampage,hidde-logius andmcking65

December 5, 2024 18:13

adampage approved these changes

Dec 5, 2024

View reviewed changes

Copy link

Member

adampage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is there a persuasive and easy-to-describe use case where all of those extremely rare conditions are sufficiently satisfied? 😅 If so, how about offering it in a note?

Otherwise, this LGTM! 🚀

Copy link

ContributorAuthor

smhigley commentedDec 5, 2024

Is there a persuasive and easy-to-describe use case where all of those extremely rare conditions are sufficiently satisfied? 😅 If so, how about offering it in a note?

Heh, my personal opinion is still thataria-checked andaria-selected never belong on the same node together. That debate happened a while ago though, and the current wording (borrowed fromoption andtreeitem) is the result 🤪