- Notifications
You must be signed in to change notification settings - Fork143
Update authoring requirement for aria-selected on options#1719
Merged
Conversation
some odd white spacing fixes and inconsistent period/capitalization between list item sentences.
Uh oh!
There was an error while loading.Please reload this page.
Contributor
JAWS-test commentedApr 13, 2022
In my opinion, this change should also be made for treeitem and not only for option. |
chlane approved these changesApr 20, 2022
Contributor
chlane left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The added specificity regarding the value looks good to me.
chlane approved these changesApr 20, 2022
mcking65 approved these changesApr 21, 2022
Contributor
mcking65 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you@smhigley! This looks great.
I agree with@JAWS-test that the same language would work in treeitem; that could be a separate PR. The related issue is about option.
Member
jnurthen commentedApr 21, 2022
ready to merge |
jnurthen pushed a commit that referenced this pull requestOct 10, 2023
A different solution for#1661, discussed on 4/7 and summarized in this comment:#1661 (comment)I wrangled the existing wording around single vs. multiselect a little because the new `SHOULD` text about `aria-selected` overlapped with the existing single vs. multi-select wording, so I consolidated a bit.* update to author requirement for aria-selected on options* minor cleanupsome odd white spacing fixes and inconsistent period/capitalization between list item sentences.* and again with the spacing...* fix spacing, update checked/selected value wordingCo-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
A different solution for#1661, discussed on 4/7 and summarized in this comment:#1661 (comment)
I wrangled the existing wording around single vs. multiselect a little because the new
SHOULDtext aboutaria-selectedoverlapped with the existing single vs. multi-select wording, so I consolidated a bit.Preview |Diff