Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/ariaPublic

update figure role#1705

Merged
pkra merged 5 commits intomainfrom
scottaohara-figure-definition-updates
Sep 1, 2022
Merged

update figure role#1705
pkra merged 5 commits intomainfrom
scottaohara-figure-definition-updates

Conversation

@scottaohara
Copy link
Member

@scottaoharascottaohara commentedMar 12, 2022•
edited by pr-previewbot
Loading

This PR requires#1703 be merged.

Preview |Diff

This PR requires#1703 be merged.
Copy link
Contributor

@chlanechlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree that aria-label and aria-labelledby can be used to label a figure element

Copy link
Contributor

@charmarkkcharmarkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree, and editorial looks good.

Copy link
Contributor

@MelSumnerMelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good. Approved the related PR as well. 👍

@pkrapkra added this to theARIA 1.3 milestoneApr 29, 2022
@pkra
Copy link
Member

@smhigley is this one ok by you now?

@pkra
Copy link
Member

pkra commentedSep 1, 2022

@scottaohara would you be able to resolve the merge conflicts?

@scottaohara
Copy link
MemberAuthor

@pkra done

pkra reacted with hooray emoji

@pkrapkra merged commitc625cb7 intomainSep 1, 2022
@pkrapkra deleted the scottaohara-figure-definition-updates branchSeptember 1, 2022 19:21
pkra pushed a commit that referenced this pull requestSep 2, 2022
* update figure role  This PR requires#1703 be merged.* Update index.html* revisions per sarah's review* further updates to figure def
jnurthen pushed a commit that referenced this pull requestOct 10, 2023
* update figure role  This PR requires#1703 be merged.* Update index.html* revisions per sarah's review* further updates to figure def
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@smhigleysmhigleysmhigley approved these changes

@MelSumnerMelSumnerMelSumner approved these changes

@charmarkkcharmarkkcharmarkk approved these changes

@chlanechlanechlane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023

Development

Successfully merging this pull request may close these issues.

6 participants

@scottaohara@pkra@smhigley@MelSumner@charmarkk@chlane

Comments

[8]ページ先頭
©2009-2026 Movatter.jp