Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/ariaPublic

role=note fleshed out a little.#1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pkra merged 10 commits intow3c:mainfrombrennanyoung:fleshing-out
Mar 3, 2023
Merged

Conversation

@brennanyoung
Copy link
Contributor

@brennanyoungbrennanyoung commentedNov 5, 2021•
edited by pr-previewbot
Loading

Language a little less terse. Explicit mention of aria-details to associate a note with another element.

Preview |Diff

Preview |Diff

Language a little less terse. Explicit mention of aria-details to associate a note with another element.
scottaohara
scottaohara previously requested changesNov 5, 2021
Normative "SHOULD" replaced with informative "can". Use cases for aria-describedby and aria-details added
@cookiecrook
Copy link
Contributor

Should this PR be linked to a particular issue?

@brennanyoung
Copy link
ContributorAuthor

@cookiecrook it arose from#1629

@w3cbot
Copy link

jnurthen marked as non substantive for IPR from ash-nazg.

@jnurthenjnurthen linked an issueNov 18, 2021 that may beclosed by this pull request
I have made edits and provided examples to flesh out the work that Brennan has started, while addressing the concerns I had noted.@brennanyoung I would ask that you review to make sure this is now clear from your end.  If so, then we can merge this branch into yours, and then request the working group to provide further review to move this along.
@scottaohara
Copy link
Member

While my commit message mentioned I was creating a separate PR to review and to then merge into this branch, unfortunately something was not working with that process, and my separate branch kept errorring out. Fortunately, through the magic of version control, we can revert / make changes to anything that need be. But as my commit message mentions,@brennanyoung please review these updates when you can. Thanks

@scottaoharascottaohara requested review fromscottaohara and removed request forscottaoharaDecember 22, 2021 22:57
@scottaohara
Copy link
Member

@jnurthen hmm, tried to remove myself from the reviewers since i've now added a bunch of content to this PR - clearly that didn't work. Worth getting someone else besides me to review now.

@jnurthenjnurthen requested review fromjnurthen andscottaohara and removed request forscottaoharaDecember 22, 2021 23:01
if one is going to make an example to show how to use `role=note`, one should remember to actually use `role=note`...
Co-authored-by: James Nurthen <jnurthen@users.noreply.github.com>
Copy link
ContributorAuthor

@brennanyoungbrennanyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good!

scottaohara reacted with thumbs up emoji
@pkrapkra added this to theARIA 1.3 milestoneJan 12, 2022
@jnurthenjnurthen requested review fromadampage and removed request foraleventhalJanuary 19, 2023 18:32
Copy link
Contributor

@cookiecrookcookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Approve with suggested editorial change.

Copy link
Member

@adampageadampage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I added a code suggestion for one small typo, otherwise this looks terrific to me. 🚀

scottaoharaand others added2 commitsJanuary 20, 2023 13:45
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
Co-authored-by: Adam Page <adamfpage@gmail.com>
@scottaohara
Copy link
Member

thank you@adampage and@cookiecrook

@jnurthen seems we can merge this now :)

@scottaohara
Copy link
Member

@pkra@jnurthen reminder about merging

pkra reacted with heart emoji

@pkrapkra merged commitabbef89 intow3c:mainMar 3, 2023
github-actionsbot added a commit that referenced this pull requestMar 3, 2023
SHA:abbef89Reason: push, by pkraCo-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jnurthen added a commit that referenced this pull requestOct 10, 2023
Language a little less terse. Explicit mention of aria-details to associate a note with another element.Co-authored-by: Brennan Young <brennan.young@laerdal.com>Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>Co-authored-by: James Nurthen <jnurthen@users.noreply.github.com>Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>Co-authored-by: Adam Page <adamfpage@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@scottaoharascottaoharascottaohara left review comments

@cookiecrookcookiecrookcookiecrook approved these changes

@adampageadampageadampage approved these changes

@jnurthenjnurthenjnurthen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023

Development

Successfully merging this pull request may close these issues.

Flesh out role=note

7 participants

@brennanyoung@cookiecrook@w3cbot@scottaohara@adampage@jnurthen@pkra
[8]ページ先頭
©2009-2025 Movatter.jp