Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/ariaPublic

Remove aria-level from listitem#1484

Merged
jnurthen merged 1 commit intow3c:mainfrom
WilliamTennisNFCU:Issue/1369_Deprecate_aria-level_on_role_listitem
Jul 2, 2021
Merged

Remove aria-level from listitem#1484
jnurthen merged 1 commit intow3c:mainfrom
WilliamTennisNFCU:Issue/1369_Deprecate_aria-level_on_role_listitem

Conversation

@WilliamTennisNFCU
Copy link
Contributor

@WilliamTennisNFCUWilliamTennisNFCU commentedMay 13, 2021•
edited by pr-previewbot
Loading

Creating a draft pull request to log work completed. I'm not sure if there is more that needs to be done, so I wanted to have this reviewed.

  • Markedaria-level deprecatedtrue on roleInfo.js forlistitem role
  • Updated documentation to note that this is deprecated in 1.3

Preview |Diff

@WilliamTennisNFCU
Copy link
ContributorAuthor

@jnurthen I have created the PR from the fork here as a draft.

@a11ydoer
Copy link
Contributor

Congratulations on your first PR,@WilliamTennisNFCU !

cookiecrook and scottaohara reacted with thumbs up emojiWilliamTennisNFCU reacted with laugh emojiWilliamTennisNFCU reacted with hooray emojiWilliamTennisNFCU reacted with heart emojipkra reacted with rocket emoji

@WilliamTennisNFCUWilliamTennisNFCUforce-pushed theIssue/1369_Deprecate_aria-level_on_role_listitem branch from654b103 to740202dCompareJune 11, 2021 00:00
@WilliamTennisNFCUWilliamTennisNFCU changed the titleDeprecate aria-level on listitemRemove aria-level from listitemJun 11, 2021
@WilliamTennisNFCUWilliamTennisNFCU marked this pull request as ready for reviewJune 11, 2021 00:07
@jnurthenjnurthen requested review fromscottaohara and removed request forcarmacleodJuly 1, 2021 17:40
Copy link
Contributor

@cookiecrookcookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Congratulations on your first approved PR,@WilliamTennisNFCU

@jnurthenjnurthen merged commit7f72832 intow3c:mainJul 2, 2021
@jnurthen
Copy link
Member

closes#1369

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cookiecrookcookiecrookcookiecrook approved these changes

@jnurthenjnurthenjnurthen approved these changes

@scottaoharascottaoharascottaohara approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023

Development

Successfully merging this pull request may close these issues.

6 participants

@WilliamTennisNFCU@a11ydoer@jnurthen@cookiecrook@scottaohara@pkra

Comments

[8]ページ先頭
©2009-2026 Movatter.jp