- Notifications
You must be signed in to change notification settings - Fork143
Conversation
removing instances of “accname required false” to be consistent with other roles which do not require a name, but do not state “false”
- require a name for `tab`- remove requirement for a name from `tooltip`
charmarkk approved these changesMay 17, 2021
carmacleod approved these changesMay 18, 2021
Contributor
carmacleod left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
+1
Totally agree with these changes.
shirsha approved these changesJun 15, 2021
jnurthen pushed a commit that referenced this pull requestJul 2, 2021
* remove instances of “false”* tab / tooltip req accname updates - require a name for `tab` - remove requirement for a name from `tooltip`
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
closes#1466
tabhave an accessible name.tooltipneeds an accessible name.Note:#1465 is related to this issue and accepting that PR will mark
formas being marked as requiring an accessible name in sections such as 5.2.8.4 Roles Supporting Name from AuthorPreview |Diff