Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/ariaPublic

add local abstract role usage warnings. fixes #1428#1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jnurthen merged 2 commits intomainfromabstract-role-warnings
May 6, 2021

Conversation

@jorycunningham
Copy link
Contributor

@jorycunninghamjorycunningham commentedApr 1, 2021•
edited by pr-previewbot
Loading

Fixes#1428

  • Adding in "Authors MUST NOT use{role name} role in content." language to each role description.
  • Remove from the paragraphs which contain the above statement
  • Moving this statement closer to the beginning of the description for longer descriptions.

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build.(Last tried on Apr 8, 2021, 7:55 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨HTML Diff Service - The HTML Diff Service is used to create HTML diffs of the spec changes suggested in a pull request.

🔗Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"><html><head><title>500 Internal Server Error</title></head><body><h1>Internal Server Error</h1><p>The server encountered an internal error ormisconfiguration and was unable to completeyour request.</p><p>Please contact the server administrator at  sysreq@w3.org to inform them of the time this error occurred, and the actions you performed just before this error.</p><p>More information about this error may be availablein the server error log.</p></body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), pleasefile an issue.

Copy link
Contributor

@carmacleodcarmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very nice! Just needs the old sentence in landmark role removed, and it's good to go!
Thanks,@jorycunningham !

Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Copy link
Contributor

@carmacleodcarmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks,@jorycunningham !
Looks good !

@carmacleod
Copy link
Contributor

(By the way, don't worry about PR Preview failing... it fails a lot).

@jnurthenjnurthen merged commit3ebb415 intomainMay 6, 2021
jnurthen pushed a commit that referenced this pull requestMay 6, 2021
* add local abstract role usage warnings.fixes#1428Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cookiecrookcookiecrookcookiecrook approved these changes

@jnurthenjnurthenjnurthen approved these changes

@carmacleodcarmacleodcarmacleod approved these changes

@scottaoharascottaoharascottaohara approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make it clearer that authors should not use abstract roles

6 participants

@jorycunningham@carmacleod@cookiecrook@jnurthen@scottaohara
[8]ページ先頭
©2009-2025 Movatter.jp