- Notifications
You must be signed in to change notification settings - Fork143
make menuitemradio subclass menuitem, require aria-checked#1354
Merged
make menuitemradio subclass menuitem, require aria-checked#1354
Conversation
Contributor
JAWS-test commentedNov 22, 2020
Theclass diagram should be updated too because it is linked at5.3 Categorization of Roles |
Member
jnurthen commentedNov 22, 2020
@JAWS-test The class diagram is no longer maintained. If you follow the link it states this. |
Contributor
JAWS-test commentedNov 24, 2020
I thought there will be a new one:#1222 |
ContributorAuthor
carmacleod commentedNov 24, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@jnurthen I think@pkra'sTree diagram from#1222 is quite nice, and we should link to it for ARIA 1.3. At a minimum, we could update it and put it at a 1.3 variant of:https://www.w3.org/WAI/ARIA/1.2/class-diagram/ |
jnurthen approved these changesDec 9, 2020
pkra approved these changesDec 11, 2020
sinabahram approved these changesDec 15, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#1347.
This PR:
Also, because menuitem superclass is now obviously a Related concept:
@WilcoFiers - would be great if you have a chance to review this. :)
Preview |Diff