- Notifications
You must be signed in to change notification settings - Fork143
Correct mistake in aria-description applicability#1193
Merged
Conversation
The aria-description property should apply to the same elementsthat aria-describedby applies to, which is all elements of thebase markup.
carmacleod approved these changesFeb 6, 2020
Contributor
carmacleod left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
+1
scottaohara approved these changesFeb 6, 2020
mcking65 approved these changesFeb 7, 2020
Contributor
mcking65 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
carmacleod pushed a commit that referenced this pull requestMay 7, 2020
The aria-description property should apply to the same elementsthat aria-describedby applies to, which is all elements of thebase markup.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The aria-description property should apply to the same elements that aria-describedby applies to, which is all elements of the base markup.
Closes#1186.
Preview |Diff