Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: inline Key components in useMagicKeys and useKeyModifier demos#4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
broBinChen wants to merge2 commits intovueuse:main
base:main
Choose a base branch
Loading
frombroBinChen:docs/inline-key-components-in-demos

Conversation

broBinChen
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • Read theContributing Guidelines.
  • Read thePull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresseswhat the PR is solving, or reference the issue that it solves (e.g.fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning:Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions.Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

This PR enhances demo isolation and maintainability by removing external component dependencies inuseMagicKeys anduseKeyModifier demo files.

What this PR solves:

1. Playground Compatibility Issues

2. Demo Isolation and Maintainability

  • Eliminates cross-file dependencies between demo files
  • Each demo becomes completely self-contained and portable
  • Reduces maintenance burden by avoiding shared component changes affecting multiple demos
  • Improves code clarity - developers can understand the complete demo logic in a single file

Additional context

OrbisK reacted with heart emoji
@dosubotdosubotbot added size:MThis PR changes 30-99 lines, ignoring generated files. documentationImprovements or additions to documentation labelsJul 16, 2025
@dosubotdosubotbot added the lgtmThis PR has been approved by a maintainer labelJul 16, 2025
@ilyaliao
Copy link
Member

@OrbisK Can't we just do itthis way?

@OrbisK
Copy link
Collaborator

OrbisK commentedJul 18, 2025•
edited
Loading

@OrbisK Can't we just do itthis way?

It is possible, yes.

I thought about this before. I think we could have a direcotry like:

- demo.vue- demo/  - comp1.vue  - comp2.vue  - example.ts

and add all files fromdemo/ to the playground.

ilyaliao reacted with thumbs up emoji

@ilyaliao
Copy link
Member

@OrbisK Can't we just do itthis way?

It is possible, yes.

I thought about this before. I think we could have a direcotry like:

- demo.vue- demo/  - comp1.vue  - comp2.vue  - example.ts

and add all files fromdemo/ to the playground.

I think this approach is better because we have many demos with similar situations, and inlining might not be practical.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OrbisKOrbisKOrbisK approved these changes

Assignees
No one assigned
Labels
documentationImprovements or additions to documentationlgtmThis PR has been approved by a maintainersize:MThis PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@broBinChen@ilyaliao@OrbisK
[8]ページ先頭
©2009-2025 Movatter.jp