Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test: add comprehensive tests for useStorageAsync#4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
broBinChen wants to merge5 commits intovueuse:main
base:main
Choose a base branch
Loading
frombroBinChen:test/add-useStorageAsync-tests

Conversation

broBinChen
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • Read theContributing Guidelines.
  • Read thePull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresseswhat the PR is solving, or reference the issue that it solves (e.g.fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning:Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions.Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

This PR adds comprehensive test coverage for theuseStorageAsync composable, which was missing test cases.

What this PR solves:

  • Adds 28 test cases covering all functionality ofuseStorageAsync
  • Ensures proper testing of async storage operations
  • Improves code quality and maintainability through better test coverage

Test coverage includes:

  • Basic data types (string, number, boolean, null, undefined)
  • Complex data structures (objects, arrays, Map, Set, Date)
  • All configuration options (eventFilter, mergeDefaults, writeDefaults, shallow, flush)
  • Error handling scenarios (read errors, write errors, serialization errors)
  • Async operations and storage synchronization
  • Edge cases and storage events

Additional context

  • This PR only adds tests without modifying the existinguseStorageAsync implementation
  • All tests are designed to work with the current async storage interface
  • The test file follows the project's testing conventions and uses the same testing utilities
  • No breaking changes or new dependencies are introduced

@dosubotdosubotbot added the size:LThis PR changes 100-499 lines, ignoring generated files. labelJul 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:LThis PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@broBinChen

[8]ページ先頭

©2009-2025 Movatter.jp