Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: use node v24#4842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
iiio2 wants to merge2 commits intovueuse:main
base:main
Choose a base branch
Loading
fromiiio2:ci/use-node-v24
Open

ci: use node v24#4842

iiio2 wants to merge2 commits intovueuse:mainfromiiio2:ci/use-node-v24

Conversation

iiio2
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • Read theContributing Guidelines.
  • Read thePull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresseswhat the PR is solving, or reference the issue that it solves (e.g.fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning:Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions.Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Additional context

@dosubotdosubotbot added the size:XSThis PR changes 0-9 lines, ignoring generated files. labelJun 27, 2025
@ilyaliaoilyaliao requested a review fromantfuJune 28, 2025 08:26
@43081j
Copy link
Collaborator

@iiio2 strangely the tests seem to fail

any idea whats up there? mostlyuseFetch

@43081j
Copy link
Collaborator

im not sure whats broken but theuseFetch tests seem pretty wrong now that i've taken a closer look at them

most importantly - they run in node, and even have a condition to only run on node>18. butuseFetch will never run in node, will it? won't every user in real life be running this in a browser?

but we can't just move them to browser tests because they spin up all sorts of node-specific server stuff to actually respond to the fetch calls. we should probably just be mocking fetch...

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@antfuantfuAwaiting requested review from antfu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size:XSThis PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@iiio2@43081j@antfu

[8]ページ先頭

©2009-2025 Movatter.jp