- Notifications
You must be signed in to change notification settings - Fork4.7k
fix: localize 404 page fix #1987#2961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hey@meteorlxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I just checked the preview link, but found an obvious flash (from en to zn)
@ulivz
So, 404 page supports i18n without my commit?
flash means session flash? |
Uh oh!
There was an error while loading.Please reload this page.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide thebefore/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding anew feature, the PR's description includes:
To avoid wasting your time, it's best to open afeature request issue first and wait for approval before working on it.
Other information: