Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: #2466 load site config from config.cjs if available#2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
soletan wants to merge1 commit intovuejs:master
base:master
Choose a base branch
Loading
fromsoletan:master

Conversation

soletan
Copy link

Summary

In context of packages declared as type module in package.json, using config.js does not work due to expecting ES modules syntax in that file and vuepress still trying to userequire() for loading. In such a context, Node.js supports extension.cjs to individually mark a file as CommonJS style. However, VuePress didn't recognize those files due to lack of explicitly looking for them. And that's what this PR is for.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide thebefore/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g.fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding anew feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open afeature request issue first and wait for approval before working on it.

Other information:

@soletansoletan changed the titlefix #2466: load site config from config.cjs if availablefix 2466: load site config from config.cjs if availableOct 3, 2021
@soletansoletan changed the titlefix 2466: load site config from config.cjs if availablefix #2466: load site config from config.cjs if availableOct 3, 2021
@soletansoletan changed the titlefix #2466: load site config from config.cjs if availablefix: #2466 load site config from config.cjs if availableOct 3, 2021
@plh97
Copy link

when will you merge this branch???

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@soletan@plh97

[8]ページ先頭

©2009-2025 Movatter.jp