- Notifications
You must be signed in to change notification settings - Fork4.7k
Fix for the Table of Contents (fix #2896)#2897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
It will be created properly when paragraph is a link - boosted `slugify` method.
Siemienik left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I confirm that works perfectly:muscle:
Example:
| Header | Current output | Expected output |
|---|---|---|
## [Test](/have/a/nice/day) | test-have-a-nice-day | test |
For me it was required to makes Table of Contents ([[toc]]) works.
@wszymanski Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for your work, could you help write a unit test for slugify function?
The table of Contents will be created properly when paragraph is a link - boosted
slugifymethod.Summary
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)