NotificationsYou must be signed in to change notification settings
Fork189
Star3.4k

New feature: $createObservableFunction#48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

yyx990803 merged 4 commits intovuejs:masterfromregou:createObservableFunction

Jul 28, 2017

Merged

New feature: $createObservableFunction#48

yyx990803 merged 4 commits intovuejs:masterfromregou:createObservableFunction

Jul 28, 2017

Conversation

Copy link

Collaborator

regou commentedJul 14, 2017•
edited
Loading

Convert function calls to observable sequence which emits the call arguments.
This make vue-rx become more collaborative with components that using callbacks

wx-ps added2 commits

July 14, 2017 18:16

$createObservableFunction

0da8f3f

readme y version

b9f6144

regou requested a review fromyyx990803

July 14, 2017 10:57

regou self-assigned this

Jul 14, 2017

indent

f47ef07

Copy link

CollaboratorAuthor

regou commentedJul 25, 2017•
edited
Loading

@yyx990803 It's been a while... Will you review this or should I merge directly ?
My fork is already on our production environment.
It'll be great if the community able to use it after the next release.

The usage is like this:
In template, normal callback
In constructor.
Maybe can save you some time.

Copy link

Member

yyx990803 commentedJul 25, 2017

@regou thanks for the PR! This one slipped through the notifications.

I've got some feedback regarding the API: when I see a method being called in the template, I tend to look for it inside themethods block, but since it's registered imperatively, it can technically appear anywhere (lifecycle hooks,subscriptions function...) So this makes it less obvious to locate where a method is defined.

Maybe similar to thedomStreams option, we can have anobservableMethods option that makes it more declarative, which just calls$createObservableMethod internally (btw,$createObservableMethod seems more consistent withmethods).