NotificationsYou must be signed in to change notification settings
Fork189
Star3.4k

test(v-stream): ensure the data gets passed correctly also on custom component#108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

regou merged 3 commits intovuejs:masterfrombriwa:add-test-v-stream-custom-component

May 17, 2019

Merged

test(v-stream): ensure the data gets passed correctly also on custom component#108

regou merged 3 commits intovuejs:masterfrombriwa:add-test-v-stream-custom-component

May 17, 2019

Conversation

Copy link

Contributor

briwa commentedMay 16, 2019•
edited
Loading

Hello. I saw a fix for#106, and I just thought that it could have been prevented by a test case so that similar problems won't happen again. What I did was just modifying the current test case forv-stream with data so that it also tests custom component instead of just a native element.

Also, just curious, why isn't the test usingvue-test-utils? Is it because it's still in beta? I don't mind doing the refactor if it should be the way to go.

Let me know what you think. Thanks.