Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

correct typedef of Route#3901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
aryanbhosale wants to merge2 commits intovuejs:dev
base:dev
Choose a base branch
Loading
fromaryanbhosale:patch-1

Conversation

aryanbhosale
Copy link

Fixes#3566

updated typedef of interface Route fromquery: Dictionary<string | (string | null)[]> toquery: Dictionary<string | null | (string | null)[]>

@netlifyNetlify
Copy link

netlifybot commentedAug 25, 2024
edited
Loading

Deploy Preview forvue-router-docs-v3 canceled.

NameLink
🔨 Latest commitdee25cf
🔍 Latest deploy loghttps://app.netlify.com/sites/vue-router-docs-v3/deploys/66cdaf9e95579c000874784d

Copy link
Member

@posvaposva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you add a test?

@aryanbhosale
Copy link
Author

Can you add a test?

Which files exactly? im kinda new to this so just the files that need to be covered would be great

@posva
Copy link
Member

@aryanbhosale
Copy link
Author

You can add it here:https://github.com/vuejs/vue-router/tree/dev/types/test

Thank you! Will have a look

@aryanbhosale
Copy link
Author

You can add it here:https://github.com/vuejs/vue-router/tree/dev/types/test

is my latest commit what you were looking for in the test?

@posva
Copy link
Member

Thanks! That should be the test. I will take a look on my next pass over vue router 3.

aryanbhosale reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@posvaposvaAwaiting requested review from posva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The type definition of Route seems to be partially wrong
2 participants
@aryanbhosale@posva

[8]ページ先頭

©2009-2025 Movatter.jp