Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5k
feat: optimize method to determine whether the two path are the same in ensureUrl methods#3477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…in ensureUrl methods
…e equal considering the order of attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you add e2e tests for both hash and html5 history as well?
| const aKeys = Object.keys(a).sort() | ||
| const bKeys = Object.keys(b).sort() | ||
| const aKeys = Object.keys(a) | ||
| const bKeys = Object.keys(b) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why should this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if that not be removed, they are the same object as below:
var a = {a:1,b:2}; var b = {b:2,a:1};Object.keys method will keep the order of attributes in an object as the attributes were added.
if that not be removed, "https://vesaas.com/?a=1&b=2" and "https://vesaas.com/?b=2&a=1" will be thought the same route.
ensureURL (push?: boolean) { const location = getHash() const plainRoute = createPlainRoute(location) if (!isSameRoute(plainRoute, this.current)) { const current = this.current.fullPath push ? pushHash(current) : replaceHash(current) } }the "ensureURL " method will not go into 'if ' block in this scene.
| @@ -149,3 +150,8 @@ export function handleRouteEntered (route: Route) { | |||
| } | |||
| } | |||
| } | |||
| /** just create a route without any added process */ | |||
| export function createPlainRoute (url: string): Route { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ideally, this function (and its tests) should be removed since we just need to callnormalizeLocation() on the url and compare it withthis.current
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
but how to compare with this current ,this.current is a Route object.I thought if it turn to a Route object , the logic can be keep smooth and complete.
I try my best to do it. |
mmeester commentedJun 24, 2021
upvote 👍 |
mmeester commentedJul 1, 2021
I've just tried the fix by@wxwzl but as far as I can determine this isn't fixing the issue that query params are sorted on init. |
Fix#3447 , optimize method to determine whether the two path are the same in ensureUrl methods