Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: add tests for SSR render#2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
niksy wants to merge3 commits intovuejs:main
base:main
Choose a base branch
Loading
fromniksy:ssr-tests
Open

Conversation

niksy
Copy link

@niksyniksy commentedAug 7, 2024
edited
Loading

This PR continues on the work of#2079 by adding missing tests removed in20352da andbased on implementation at v15 version of loader.

SSR context styles are not present since I couldn’t get final result inside context. As I see it, that currently isn’t possible since all the CSS is automatically extracted, but maybe it could be achivede with additional loader after all the CSS has been preprocessed?

v15 version relies on vue-style-loader so I think that’s why it was possible to get all the necessary information.

Also, hashing function from original PR has been moved fromhash-sum to internal one to align with Vite and other hashing behavior. It’s possible that this could clash withNuxt Vue client manifest package implementation.

@sodatea Is it possible we can get this implemented? This would greatly help with collecting all the necessary components needed for initial render in SSR contexts. After that, maybe we could work on critical CSS implementation.

@niksyniksy changed the titlefix: add test for SSR renderfix: add tests for SSR renderAug 7, 2024
@OskarLebuda
Copy link

Good job 👍🏻 I've done it myself but this requires fork of this repo.
The official way should be provided.@yyx990803@haoqunjiang approve this PR and make some release with that?

niksy and dmitryuk reacted with thumbs up emoji

@dmitryuk
Copy link

dmitryuk commentedNov 15, 2024
edited
Loading

Thanks for you PR! Waiting to be merged soon

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@niksy@OskarLebuda@dmitryuk@mog422

[8]ページ先頭

©2009-2025 Movatter.jp