fix(v15): loaders for styles are not deduplicated when experiments.css is true#2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

xc2 wants to merge1 commit intovuejs:master

base:master

Choose a base branch

fromxc2:fix-duplicate-style-loaders

Open

fix(v15): loaders for styles are not deduplicated when experiments.css is true#2071

xc2 wants to merge1 commit intovuejs:masterfromxc2:fix-duplicate-style-loaders

Conversation

Copy link

xc2 commentedApr 15, 2024

relatedweb-infra-dev/rsbuild#2093

cause:

genRequest who does the deduplicating is not called for the branch forexperiments.css === true

vue-loader/lib/loaders/pitcher.js

Lines 126 to 161 in96a7493

	if(isWebpack5&&this._compiler.options.experiments&&this._compiler.options.experiments.css){
	// If user enables `experiments.css`, then we are trying to emit css code directly.
	// Although we can target requests like `xxx.vue?type=style` to match `type: "css"`,
	// it will make the plugin a mess.
	if(!options.experimentalInlineMatchResource){
	this.emitError(
	newError(
	'`experimentalInlineMatchResource` should be enabled if `experiments.css` enabled currently'
	)
	)
	return''
	}

	if(query.inline\|\|query.module){
	this.emitError(
	newError(
	'`inline` or `module` is currently not supported with `experiments.css` enabled'
	)
	)
	return''
	}

	constloaderString=[stylePostLoaderPath, ...loaders]
	.map((loader)=>{
	returntypeofloader==='string' ?loader :loader.request
	})
	.join('!')

	conststyleRequest=loaderUtils.stringifyRequest(
	this,
	`${this.resourcePath}${query.lang ?`.${query.lang}` :''}${
	this.resourceQuery
	}!=!-!${loaderString}!${this.resourcePath+this.resourceQuery}`
	)
	return`@import${styleRequest};`
	}

fix: loaders for styles are not deduplicated when experiments.css is …

3ed63fa

…true

xc2 changed the title~~fix: loaders for styles are not deduplicated when experiments.css is true~~fix(v15): loaders for styles are not deduplicated when experiments.css is true

Apr 15, 2024

This was referencedApr 15, 2024

[Bug]: @rsbuild/plugin-vue2 runs duplicating loaders for less code in sfcweb-infra-dev/rsbuild#2093

Closed

fix(plugin-vue2): fix loaders duplicating problem caused by vue-loader@15web-infra-dev/rsbuild#2142

Merged